-
Notifications
You must be signed in to change notification settings - Fork 352
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Set tunnel name to wg0-mullvad for wireguard-go #6713
Conversation
76f7c38
to
70c3ae0
Compare
70c3ae0
to
caa8a49
Compare
d603aba
to
63fa400
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 7 of 8 files at r1, 1 of 1 files at r2, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @MarkusPettersson98)
talpid-tunnel/src/tun_provider/unix.rs
line 109 at r2 (raw file):
/// Create a [`TunnelDevice`] from this builder. /// /// Note: this function may fail if <TODO>
TODO
Code quote:
/// Note: this function may fail if <TODO>
20fcdb8
to
ef56ce6
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewable status: 7 of 8 files reviewed, 1 unresolved discussion (waiting on @MarkusPettersson98)
talpid-tunnel/src/tun_provider/unix.rs
line 109 at r2 (raw file):
Previously, MarkusPettersson98 (Markus Pettersson) wrote…
TODO
Done. I don't think it makes sense to list all of the reasons here, and no particular reasons come to mind, so I've just removed it.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 1 of 1 files at r3, all commit messages.
Reviewable status:complete! all files reviewed, all discussions resolved
Co-authored-by: Markus Pettersson <[email protected]>
ef56ce6
to
6df6115
Compare
Currently, the interface is unnamed (
tunX
) for wggo, but not kernel WireGuard. The PR simply fixes this and uses the same alias in both cases.Fix DES-1210
This change is