Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set tunnel name to wg0-mullvad for wireguard-go #6713

Merged
merged 2 commits into from
Sep 2, 2024
Merged

Conversation

dlon
Copy link
Member

@dlon dlon commented Aug 31, 2024

Currently, the interface is unnamed (tunX) for wggo, but not kernel WireGuard. The PR simply fixes this and uses the same alias in both cases.

Fix DES-1210


This change is Reviewable

@dlon dlon force-pushed the set-wggo-tun-name branch 2 times, most recently from 76f7c38 to 70c3ae0 Compare September 2, 2024 08:11
@dlon dlon marked this pull request as ready for review September 2, 2024 08:12
@dlon dlon changed the title Set tunnel interface name to wg0-mullvad when wireguard-go is enabled Set tunnel name to wg0-mullvad for wireguard-go Sep 2, 2024
@dlon dlon force-pushed the set-wggo-tun-name branch from 70c3ae0 to caa8a49 Compare September 2, 2024 08:13
Copy link

linear bot commented Sep 2, 2024

@dlon dlon force-pushed the set-wggo-tun-name branch 2 times, most recently from d603aba to 63fa400 Compare September 2, 2024 10:27
Copy link
Contributor

@MarkusPettersson98 MarkusPettersson98 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 7 of 8 files at r1, 1 of 1 files at r2, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @MarkusPettersson98)


talpid-tunnel/src/tun_provider/unix.rs line 109 at r2 (raw file):

    /// Create a [`TunnelDevice`] from this builder.
    ///
    /// Note: this function may fail if <TODO>

TODO

Code quote:

/// Note: this function may fail if <TODO>

@dlon dlon force-pushed the set-wggo-tun-name branch 2 times, most recently from 20fcdb8 to ef56ce6 Compare September 2, 2024 11:25
Copy link
Member Author

@dlon dlon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewable status: 7 of 8 files reviewed, 1 unresolved discussion (waiting on @MarkusPettersson98)


talpid-tunnel/src/tun_provider/unix.rs line 109 at r2 (raw file):

Previously, MarkusPettersson98 (Markus Pettersson) wrote…

TODO

Done. I don't think it makes sense to list all of the reasons here, and no particular reasons come to mind, so I've just removed it.

Copy link
Contributor

@MarkusPettersson98 MarkusPettersson98 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 1 of 1 files at r3, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved

@dlon dlon force-pushed the set-wggo-tun-name branch from ef56ce6 to 6df6115 Compare September 2, 2024 13:01
@dlon dlon merged commit d0040f9 into main Sep 2, 2024
53 of 54 checks passed
@dlon dlon deleted the set-wggo-tun-name branch September 2, 2024 13:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants