Remove incorrect default arguments #7314
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Rawa
force-pushed
the
remove-empty-lambda-default-arguments-in-screens-and-dialogs-droid-1526
branch
from
dba4496 to
5566243
Compare
Rawa
force-pushed
the
remove-empty-lambda-default-arguments-in-screens-and-dialogs-droid-1526
branch
from
5566243 to
e7cd83e
Compare
Pururun
approved these changes
Dec 11, 2024
There was a problem hiding this comment.
Reviewed 74 of 74 files at r1, all commit messages.
Reviewable status:complete! all files reviewed, all discussions resolved
Pururun
added
the
On hold
Rawa
force-pushed
the
remove-empty-lambda-default-arguments-in-screens-and-dialogs-droid-1526
branch
from
e7cd83e to
90174b2
Compare
Rawa
removed
the
On hold
Rawa
deleted the
remove-empty-lambda-default-arguments-in-screens-and-dialogs-droid-1526
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We've been lazy when it comes to creating our screens and dialog, they have a lot of empty default click handlers. While this can be convientient in some cases, e.g testing, it can also be dangerous when a argument is left out. This PR removes all the default arguments from the Screens and Dialogs.
This change is