manually searching for song lyrics

[rocus]

Suppose there is no lyrics for song: artista-title. I suspect there are lyrics for the song: artistb-title. Manually searching for artistb-title finds these lyrics but saves them as artistb-title.txt. (see logging file)

I think it is logical to save them under title artista-title.txt. This might also solve the problem that even when lyrics are found in the info window "lyrics not found" is shown and no lyrics are shown.

This worked correctly in the old version 1.6.2.1 that is, it worked correctly after I moved the line dialog.destroy() in main.py a few lines to the south.

[multani]

Hi Rocus,

You are actually right, it's more logical this way and this should not be too difficult to fix.

One thing though: this will be a backward incompatible change (lyrics saved under artist-b-title will not be found after we fix this). I'm not sure if we have to handle this case, but just a thought.

[rocus]

I don't understand your remark about backwards compatibility. In the version 1.6.2.1 it worked correctly: it saved the lyrics as artist-a-title.txt (while manually searching for artist-b-title).

Maybe you are referring to a version between 1.6.2.1 and 1.7a2-78.

Whatever, it seems logical to me that when no lyrics are found and you find them manually (by entering another artist or correcting a spelling mistake) the second time you play that song the lyrics are found automatically (in the .lyrics directory) and you don't have to do the exercise again.

Maybe you mean that when later you listen to the song artist-b-title the lyrics are not immediately found (in .lyrics) but must be fetched from the internet. After that you have 2 identical files (with the same content) but with different names. That seems no problem to me though.

[multani]

Hum, OK, I didn't know there was a regression (that is, it saved artist-a-title.txt but now it saves artist-b-title.txt) for this in our master branch. This ought to be fixed then.