Skip to content

Commit

Permalink
Squash to "selftests/bpf: Add mptcp subflow subtest"
Browse files Browse the repository at this point in the history
Should use dedicated ASSERT_OK_FD() to check the fds.

Signed-off-by: Geliang Tang <[email protected]>
Message-Id: <d5598209aecfc8fe58f9a93dc802817b041785a9.1725680751.git.tanggeliang@kylinos.cn>
  • Loading branch information
Geliang Tang authored and Patchew Applier committed Sep 7, 2024
1 parent 1d732d3 commit 0145299
Showing 1 changed file with 3 additions and 3 deletions.
6 changes: 3 additions & 3 deletions tools/testing/selftests/bpf/prog_tests/mptcp.c
Original file line number Diff line number Diff line change
Expand Up @@ -394,11 +394,11 @@ static void run_subflow(void)
socklen_t len;

server_fd = start_mptcp_server(AF_INET, ADDR_1, PORT_1, 0);
if (!ASSERT_GE(server_fd, 0, "start_mptcp_server"))
if (!ASSERT_OK_FD(server_fd, "start_mptcp_server"))
return;

client_fd = connect_to_fd(server_fd, 0);
if (!ASSERT_GE(client_fd, 0, "connect to fd"))
if (!ASSERT_OK_FD(client_fd, "connect_to_fd"))
goto close_server;

send_byte(client_fd);
Expand Down Expand Up @@ -429,7 +429,7 @@ static void test_subflow(void)
struct bpf_link *link;

cgroup_fd = test__join_cgroup("/mptcp_subflow");
if (!ASSERT_GE(cgroup_fd, 0, "join_cgroup: mptcp_subflow"))
if (!ASSERT_OK_FD(cgroup_fd, "join_cgroup: mptcp_subflow"))
return;

skel = mptcp_subflow__open_and_load();
Expand Down

0 comments on commit 0145299

Please sign in to comment.