Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BPF: setsockopt on an MPTCP socket: check support #484

Open
matttbe opened this issue Apr 4, 2024 · 0 comments
Open

BPF: setsockopt on an MPTCP socket: check support #484

matttbe opened this issue Apr 4, 2024 · 0 comments
Assignees

Comments

@matttbe
Copy link
Member

matttbe commented Apr 4, 2024

We have recommended to use BPF to set socket option per subflow (see #76), on TCP socket then.

But it looks like we didn't check if we can correctly do some setsockopt() on MPTCP sockets, especially the ones iterating over the different subflows. It would be good to add a test in the BPF selftests to unsure this case is covered, and verify with LOCKDEP that everything is OK there.

The reason behind that: doing a setsockopt on an MPTCP socket from BPF might be a problem if this is done in an atomic context (MPTCP will then lock the subflows, etc.)

@matttbe matttbe changed the title BPF: setsockopt on an MPTCP socket: check support BPF: getsockopt on an MPTCP socket: check support Apr 25, 2024
@matttbe matttbe changed the title BPF: getsockopt on an MPTCP socket: check support BPF: setsockopt on an MPTCP socket: check support Apr 25, 2024
@geliangtang geliangtang self-assigned this Sep 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants