Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change the color of time complexity chart. #16

Closed
multiverseweb opened this issue Oct 1, 2024 · 24 comments
Closed

Change the color of time complexity chart. #16

multiverseweb opened this issue Oct 1, 2024 · 24 comments
Assignees

Comments

@multiverseweb
Copy link
Owner

In light mode, the color of time complexity chart should be black.

image

@nithinrvs
Copy link

Hello, Please assign it to me. i would like to work on it.

@ShivanshPlays
Copy link

Hi @multiverseweb , I think you need something like this

image

I've already started working on it, It'll be great if you assign this issue it to me....

@Hustler004
Copy link
Contributor

Hi I would really love an opportunity to contribute on this issue!

@ShivanshPlays
Copy link

Hi any update? @multiverseweb

@multiverseweb
Copy link
Owner Author

@ShivanshPlays yes, that is what I want, assigning it to you.
The color does not need to be black exactly, its looking a bit odd. Make it a bit lighter.

@ShivanshPlays
Copy link

Okay, I am on it.

@ankurrrrr7
Copy link
Contributor

assign please
@multiverseweb

@multiverseweb
Copy link
Owner Author

@ankurrrrr7 look for the issues that have not been assigned yet.

@ankurrrrr7
Copy link
Contributor

@multiverseweb bhaiya karliya abhi karoon pr fix hogya yeh!

@multiverseweb
Copy link
Owner Author

@ankurrrrr7 okay, go ahead.

@BaniSinghgithub
Copy link

hello sir @multiverseweb , can you pls assign me this task.

@multiverseweb
Copy link
Owner Author

Sure @BaniSinghgithub, assigned.

@multiverseweb
Copy link
Owner Author

Any updates @BaniSinghgithub?

@ShivanshPlays
Copy link

@multiverseweb sorry totally missed this one, can you assign me, I'll raise the PR by tomorrow

@multiverseweb
Copy link
Owner Author

Sure @ShivanshPlays, make sure the color of the grid lines and numbers on the graph should change. Unlike adding background like this:
image

The PR will be merged on First Come First Serve basis.

@multiverseweb
Copy link
Owner Author

Hi @multiverseweb , I think you need something like this

image

I've already started working on it, It'll be great if you assign this issue it to me....

@ShivanshPlays
Try changing the color of numbers on the axes too.

@ShivanshPlays
Copy link

understood

@multiverseweb
Copy link
Owner Author

Hey @ShivanshPlays, are you working on this issue or shall we close this?

@raavan4m3
Copy link

@multiverseweb If the approach meets the expected standards, please consider merging this enhancement. Thank you for the opportunity to contribute!

Screenshot 2024-11-08 182835

@raavan4m3
Copy link

@multiverseweb
I have completed the changes as requested and have submitted a pull request for review. Please take a look at it when you have a chance.

Let me know if there are any further changes or adjustments needed.

@multiverseweb
Copy link
Owner Author

Hey @raavan4m3 actually this is what is required:
image

I hope you can change the color of graph like this

@raavan4m3
Copy link

@multiverseweb
Screenshot 2024-11-09 123056

@multiverseweb
Copy link
Owner Author

@raavan4m3 Yes, this looks good

raavan4m3 added a commit to raavan4m3/CodeIt that referenced this issue Nov 9, 2024
@raavan4m3
Copy link

@multiverseweb
I have completed the changes as required and have submitted a pull request for review.
Screenshot 2024-11-09 123056

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

7 participants