From ea9ccbcab8b6d8fb49910b0b538ede90fb3d34d7 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Andrei=20B=C4=83ncioiu?= Date: Tue, 15 Oct 2024 13:00:11 +0300 Subject: [PATCH 1/2] Additional tests. --- src/testdata/README.md | 33 ++++++-- src/testdata/transactions.mainnet.json | 80 +++++++++++++++++++ ...TransactionsOutcomeParser.main.net.spec.ts | 24 ++++++ 3 files changed, 131 insertions(+), 6 deletions(-) diff --git a/src/testdata/README.md b/src/testdata/README.md index 99bce0e0..841b24e3 100644 --- a/src/testdata/README.md +++ b/src/testdata/README.md @@ -12,7 +12,7 @@ DECLARE -- Contract execute, with success ( SELECT - `_id`, + `_id` `hash`, 'execute_success' `kind` FROM `multiversx-blockchain-etl.crypto_multiversx_mainnet_eu.transactions` @@ -29,7 +29,7 @@ UNION ALL -- Contract execute, with error ( SELECT - `_id`, + `_id` `hash`, 'execute_error' `kind` FROM `multiversx-blockchain-etl.crypto_multiversx_mainnet_eu.transactions` @@ -46,7 +46,7 @@ UNION ALL -- Contract transfer & execute, with success ( SELECT - `_id`, + `_id` `hash`, 'transfer_execute_success' `kind` FROM `multiversx-blockchain-etl.crypto_multiversx_mainnet_eu.transactions` @@ -63,7 +63,7 @@ UNION ALL -- Contract transfer & execute, with error ( SELECT - `_id`, + `_id` `hash`, 'transfer_execute_error' `kind` FROM `multiversx-blockchain-etl.crypto_multiversx_mainnet_eu.transactions` @@ -80,7 +80,7 @@ UNION ALL -- Relayed, with success ( SELECT - `_id`, + `_id` `hash`, 'relayed_success' `kind` FROM `multiversx-blockchain-etl.crypto_multiversx_mainnet_eu.transactions` @@ -96,7 +96,7 @@ UNION ALL -- Relayed, with failure ( SELECT - `_id`, + `_id` `hash`, 'relayed_error' `kind` FROM `multiversx-blockchain-etl.crypto_multiversx_mainnet_eu.transactions` @@ -108,4 +108,25 @@ UNION ALL AND RAND() < 0.25 LIMIT 50) +UNION ALL + -- MultiESDTNFTTransfer, with too much gas + ( + SELECT + `_id` `hash`, + 'multi_transfer_too_much_gas' `kind` + FROM + `multiversx-blockchain-etl.crypto_multiversx_mainnet_eu.transactions` + WHERE + DATE(`timestamp`) >= TIMESTAMP_START + AND DATE(`timestamp`) <= TIMESTAMP_END + AND `operation` = 'MultiESDTNFTTransfer' + AND `function` IS NULL + AND `isRelayed` IS NULL + AND `status` = 'success' + AND `gasLimit` = `gasUsed` + AND ARRAY_LENGTH(`tokens`) = 1 + AND `receiversShardIDs`[0] != `senderShard` + AND RAND() < 0.25 + LIMIT + 20) ``` diff --git a/src/testdata/transactions.mainnet.json b/src/testdata/transactions.mainnet.json index d9c324e4..0be4e0b9 100644 --- a/src/testdata/transactions.mainnet.json +++ b/src/testdata/transactions.mainnet.json @@ -11506,5 +11506,85 @@ { "hash": "a7c20ed14474fad25b3a2c089fae2a45a5c5d11b1ea7574de32542571b46440a", "kind": "relayed_error" + }, + { + "hash": "6e0414891686baf7a21c27c24b09e16fe9c3bce040b1bb504a40f4ddf506f402", + "kind": "multi_transfer_too_much_gas" + }, + { + "hash": "3206004a1366581669210845baa1eca90336534e391f81bd01dfe998da4cec40", + "kind": "multi_transfer_too_much_gas" + }, + { + "hash": "c8c164f1597410abc8eae16b660e8d446423b2566d5a8b7617430e0bced0257d", + "kind": "multi_transfer_too_much_gas" + }, + { + "hash": "bb9fb4ca0494ab060aa9ccaf4f24438d0ba2d09127178b97725df3dfa470c264", + "kind": "multi_transfer_too_much_gas" + }, + { + "hash": "f7df0d7180c70b74706ec54a77c56bef02f86dffe5ac2367816b5537559a1aff", + "kind": "multi_transfer_too_much_gas" + }, + { + "hash": "251c7805dd1004ce6f33a2932e237cc2cc41c945683100cd1c23f5de9bccd058", + "kind": "multi_transfer_too_much_gas" + }, + { + "hash": "104187750797f102e3cd223f5a7e3f05bf31ce22606eef9c75318178eb8c6713", + "kind": "multi_transfer_too_much_gas" + }, + { + "hash": "c4511ee6580b3460b0a80dad8514c0998fb006c7e5896831f307211360654c31", + "kind": "multi_transfer_too_much_gas" + }, + { + "hash": "4c4327edcc77e4d8f3de27ecb37cdd898620a6aa46077d7c75b3b637c2d07a60", + "kind": "multi_transfer_too_much_gas" + }, + { + "hash": "f3873ef6f68eab202b775a3b1bec603ceea138031819f290249ad4fbfbb24871", + "kind": "multi_transfer_too_much_gas" + }, + { + "hash": "0209629e347c84714eeb50cb6561b5053e55cc504062eaf70cbfcac5e14f27b5", + "kind": "multi_transfer_too_much_gas" + }, + { + "hash": "9f381f611328b20cce90d18eff81a7532451b858711892ef0e3c29f80d6dceff", + "kind": "multi_transfer_too_much_gas" + }, + { + "hash": "22edc571dd43166a30c0af4182d69c2a628b2543c09724042b6680c0042e0a9e", + "kind": "multi_transfer_too_much_gas" + }, + { + "hash": "8b3b99a33b1b47377fe2c699244c8c137716a1ca8e8cca7f1c48b32a77f0751e", + "kind": "multi_transfer_too_much_gas" + }, + { + "hash": "53dfadaea88e58da21f698f10a1949cc51c4a2cc88a061474ff1f43c2190c752", + "kind": "multi_transfer_too_much_gas" + }, + { + "hash": "080d3a888c140a1664da1f0df59e716da84e377d91e50af45cfd65695c28fcca", + "kind": "multi_transfer_too_much_gas" + }, + { + "hash": "72736705d7cc350ba9ad9c6bd811e744a7c09ce948e2a3982475bc4adcc609a5", + "kind": "multi_transfer_too_much_gas" + }, + { + "hash": "dc534504eb937a0aaac4189ad774dcb1cad32f72b35f31f77370997dc2e1c17c", + "kind": "multi_transfer_too_much_gas" + }, + { + "hash": "122b1bfe8cd22e853708c130be8b8226dfd53380a4e3bd0a56faa8eb66bbe0f6", + "kind": "multi_transfer_too_much_gas" + }, + { + "hash": "a794915071d0924922546fabc67202a06e9d56fb64cda21fa8a235826ae2e3cd", + "kind": "multi_transfer_too_much_gas" } ] diff --git a/src/transactionsOutcomeParsers/smartContractTransactionsOutcomeParser.main.net.spec.ts b/src/transactionsOutcomeParsers/smartContractTransactionsOutcomeParser.main.net.spec.ts index dbe83452..d8054aa9 100644 --- a/src/transactionsOutcomeParsers/smartContractTransactionsOutcomeParser.main.net.spec.ts +++ b/src/transactionsOutcomeParsers/smartContractTransactionsOutcomeParser.main.net.spec.ts @@ -126,6 +126,30 @@ describe("test smart contract transactions outcome parser on mainnet", () => { } }); + it("should parse (multi_transfer_too_much_gas)", async function () { + this.timeout(3600000); + + const records = await loadRecords("multi_transfer_too_much_gas"); + + for (let i = 0; i < records.length; i++) { + const { hash } = records[i]; + console.log(i, hash); + + const transactionOnNetwork = await networkProvider.getTransaction(hash); + const transactionOutcome = converter.transactionOnNetworkToOutcome(transactionOnNetwork); + const parsedOutcomeGivenTransactionOutcome = parser.parseExecute({ transactionOutcome }); + const parsedOutcomeGivenTransactionOnNetwork = parser.parseExecute({ transactionOnNetwork }); + + assert.deepEqual(parsedOutcomeGivenTransactionOutcome, parsedOutcomeGivenTransactionOnNetwork); + assert.isTrue(parsedOutcomeGivenTransactionOnNetwork.returnCode.length > 0); + assert.isTrue(parsedOutcomeGivenTransactionOnNetwork.returnMessage.length > 0); + assert.lengthOf(parsedOutcomeGivenTransactionOnNetwork.values, 0); + + assert.equal(parsedOutcomeGivenTransactionOnNetwork.returnCode, "ok"); + assert.equal(parsedOutcomeGivenTransactionOnNetwork.returnMessage, "ok"); + } + }); + async function loadRecords(kind: string): Promise { const path = "src/testdata/transactions.mainnet.json"; const content: string = await promises.readFile(path, { encoding: "utf8" }); From 6e77bcb45cbcbad5e9b8a2d94a34c2d51282cf59 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Andrei=20B=C4=83ncioiu?= Date: Tue, 15 Oct 2024 13:02:23 +0300 Subject: [PATCH 2/2] Simplify tests. --- .../smartContractTransactionsOutcomeParser.main.net.spec.ts | 5 +---- 1 file changed, 1 insertion(+), 4 deletions(-) diff --git a/src/transactionsOutcomeParsers/smartContractTransactionsOutcomeParser.main.net.spec.ts b/src/transactionsOutcomeParsers/smartContractTransactionsOutcomeParser.main.net.spec.ts index d8054aa9..00ee2773 100644 --- a/src/transactionsOutcomeParsers/smartContractTransactionsOutcomeParser.main.net.spec.ts +++ b/src/transactionsOutcomeParsers/smartContractTransactionsOutcomeParser.main.net.spec.ts @@ -141,12 +141,9 @@ describe("test smart contract transactions outcome parser on mainnet", () => { const parsedOutcomeGivenTransactionOnNetwork = parser.parseExecute({ transactionOnNetwork }); assert.deepEqual(parsedOutcomeGivenTransactionOutcome, parsedOutcomeGivenTransactionOnNetwork); - assert.isTrue(parsedOutcomeGivenTransactionOnNetwork.returnCode.length > 0); - assert.isTrue(parsedOutcomeGivenTransactionOnNetwork.returnMessage.length > 0); - assert.lengthOf(parsedOutcomeGivenTransactionOnNetwork.values, 0); - assert.equal(parsedOutcomeGivenTransactionOnNetwork.returnCode, "ok"); assert.equal(parsedOutcomeGivenTransactionOnNetwork.returnMessage, "ok"); + assert.lengthOf(parsedOutcomeGivenTransactionOnNetwork.values, 0); } });