Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement a scrollbar for widgets that support scrolling #164

Open
mum4k opened this issue Mar 3, 2019 · 2 comments
Open

Implement a scrollbar for widgets that support scrolling #164

mum4k opened this issue Mar 3, 2019 · 2 comments
Labels
enhancement New feature or request help wanted Extra attention is needed

Comments

@mum4k
Copy link
Owner

mum4k commented Mar 3, 2019

For now that would be Text and Table.

The scrollbar should give a visual aid to the relative location of scrolling and allow clicking to scroll faster or skip larger portions of the data.

@mum4k mum4k added the enhancement New feature or request label Mar 3, 2019
@slok
Copy link
Contributor

slok commented Apr 27, 2019

I don't know if this could be related with this or not and better be in another issue, if is the second one I'll create a new issue to track this if you see valuable and possible (effort/value).

Would be nice to mark as scrollable (vertical) any element on the terminal, this is widgets or containers (example a row). I don't know how it would be designed and/or implemented, but I will try to explain:

In the end would be nice to get the same user experience as if you were on a web page, this is, mark a max height on the containers of the grid and if the widgets/containers inside this "scrollable" container are bigger (height) than that, the container would activate the scroll, setting a scroll visualization (could be optional) and giving the user the ability to scroll all the visual stuff inside this container (multiple containers and widgets).

With this, we could gain the ability to create terminal visualizations that aren't limited vertically by the terminal size.

@mum4k
Copy link
Owner Author

mum4k commented Apr 28, 2019

Thanks @slok, this a very good idea. I have filled #192 to track it. This will need some more thought as to how we design it, but I see it being very useful.

I will leave this issue to track the drawing of a scrollbar in Table and Text. However if we do our job right in #192, this might become obsolete.

@mum4k mum4k added the help wanted Extra attention is needed label May 3, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

2 participants