Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Client roaming (stay connected when network connection changes) #6427

Open
blafjoll opened this issue May 23, 2024 · 6 comments
Open

Client roaming (stay connected when network connection changes) #6427

blafjoll opened this issue May 23, 2024 · 6 comments
Labels
client feature-request This issue or PR deals with a new feature server

Comments

@blafjoll
Copy link

Description

When the client changes ip address while connected, the user hangs, and has to wait for the 30s timeout to reconnect.
This happens when mobile clients go from cellular to wifi and back.

Steps to reproduce

Connect with mobile client and turn on/off wifi or walk into/out of range of wifi.

Mumble version

No response

Mumble component

Server

OS

Linux

Reproducible?

Yes

Additional information

No response

Relevant log output

No response

Screenshots

No response

@blafjoll blafjoll added bug A bug (error) in the software triage This issue is waiting to be triaged by one of the project members labels May 23, 2024
@Hartmnt
Copy link
Member

Hartmnt commented May 23, 2024

I think this is an inherent property of TCP/IP and can not be solved by us.

@davidebeatrici
Copy link
Member

More specifically, this is not a bug but rather a feature request: implement client roaming.

@Krzmbrzl
Copy link
Member

@davidebeatrici how would that look like?

@davidebeatrici
Copy link
Member

Well, both client and server need changes in order to support roaming properly (and it's quite complex to get right).

As a start, the server should detect when a client that was already connected connects again (before the timeout is triggered) and treat the situation as if nothing happened. The client should attempt to connect before the timeout is reached server-side.

@Krzmbrzl
Copy link
Member

I wonder whether this might not simply be out of scope for Mumble. Sounds like an awful lot of work for a presumably rather rare edge case 🤔

@Hartmnt
Copy link
Member

Hartmnt commented May 30, 2024

Just glancing over the complexity of the issue in my head, I fear that this would open a large can of worms. (Would this interfere with the TLS handshake? What happens when multiple users connect from the same IP? 🤔)

I would say, let us consider this a feature request, but note that we would have to think this through carefully, if someone would ever try to implement this.

@Hartmnt Hartmnt added client server feature-request This issue or PR deals with a new feature and removed bug A bug (error) in the software triage This issue is waiting to be triaged by one of the project members labels May 30, 2024
@Krzmbrzl Krzmbrzl changed the title changing ip address on the fly Client roaming (stay connected when network connection changes) May 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
client feature-request This issue or PR deals with a new feature server
Projects
None yet
Development

No branches or pull requests

4 participants