Multiple message invoked

[Neloy262]

Description

In the mumble server two users with the same name can be connected at once. In this case we are seeing that the user that joined last is getting sent the same proto msg twice from the server. If three users with the same name are connected then the 3rd user is getting the proto msg thrice and so on.

Steps to reproduce

1. Have multiple users with the same name join the server.

Mumble version

1.5.0

Mumble component

Both

OS

Linux

Reproducible?

Yes

Additional information

No response

Relevant log output

No response

Screenshots

No response

[Krzmbrzl]

User's shouldn't be able to use the same username

mumble/src/murmur/Messages.cpp

Lines 243 to 261 in edd4588

	ServerUser *uOld = nullptr;
	foreach (ServerUser *u, qhUsers) {
	if (u == uSource)
	continue;
	if (((u->iId >= 0) && (u->iId == uSource->iId)) || (u->qsName.toLower() == uSource->qsName.toLower())) {
	uOld = u;
	break;
	}
	}
	// Allow reuse of name from same IP
	if (ok && uOld && (uSource->iId == -1)) {
	if ((uOld->peerAddress() != uSource->peerAddress())
	&& (uSource->qsHash.isEmpty() || (uSource->qsHash != uOld->qsHash))) {
	reason = "Username already in use";
	rtType = MumbleProto::Reject_RejectType_UsernameInUse;
	ok = false;
	}
	}

Could you give specifics on your exact server setup and what usernames you are using (and whether a user with that username is registered on that server)?

[github-actions]

This issue has been marked as stale, because our request for more information has thus far not been fulfilled.

If no further action occurs, this issue will be closed within 7 days.