fix (app): Fix list elements jumping out of position when dragged #300
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
All contributors have signed the CLC ✍️ ✅ |
|
I have read the CLC Document and I hereby sign the CLC |
github-merge-queue bot
pushed a commit
that referenced
this pull request
Feb 4, 2025
Partially fixes .#295, allowing Page links to be edited and reordered on the Profile edit page. https://github.com/user-attachments/assets/8b244070-66b8-4734-98f9-8032ba7bbb7c There's some callouts in the code comments I'm adding here for visibility: - Sorting here is also affected by the bug the #300 fixes, but works correctly if that is also merged. - rodrigodagostino/svelte-sortable-list#11. This was fixed in svelte-sortable-list v0.10.11. I didn't want to edit package.json without explaining why first. - The last empty element can get dragged into the list (and then erased). There isn't a way to lock it while leaving it editable. Opened an issue for it here (rodrigodagostino/svelte-sortable-list#15) - Tab order for sortable covers the individual inputs. Not sure how to best to accessibly deal with this. - Copied and edited some $effects from SocialLinksEditor.svelte to keep an empty input on the list. Might be worth abstracting and merging if the same thing is needed in more places. - Links get auto removed when the url is empty without checking the label. I don't know which would make more sense / how likely someone is to delete an entire url when they plan to reuse it's label.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For reasons I don't understand dragging elements from svelte-sortable-list seems to break when it's parent has a
backdrop-filter.