Bandcamp: Correctly split "artist - title" #446
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Use a non-greedy expression for the artist as the title might contain " - ".
|
I would like to have a second opinion regarding 1bfdf8a, since I am not entirely sure how often the two cases actually occur. Examples which I used for testing:
|
kellnerd
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes ESLint errors and bumps the version (still necessary after #441 has been merged).(Directly pushed tomasteras I don't want to further delay the version bump.)Correctly splits "artist - title" patterns for releases with per-track artists using a non-greedy expression for the artist as the title might contain the " - " separator (e.g. for ETI). It might be possible in certain cases that the artist credit contains the separator instead, but I'd rather accidentally have an artist as part of the title (rarer and easier to fix, especially if " - " separates multiple artists which have to be split anyway) than the artist containing parts of the title.