Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove tashkeel #9

Open
thewh1teagle opened this issue Aug 30, 2024 · 3 comments
Open

Remove tashkeel #9

thewh1teagle opened this issue Aug 30, 2024 · 3 comments

Comments

@thewh1teagle
Copy link

thewh1teagle commented Aug 30, 2024

I suggest putting tashkeel in another crate / repo or behind feature flag since it has errors and it's not related directly.

Would you mind let me know what's the status of the project so I'll know what to expect? as I don't see it published. I don't want to waste time on PRs if you don't plan to publish it. Thanks.

@mush42
Copy link
Owner

mush42 commented Aug 31, 2024

Hi @thewh1teagle

Sounds good enough. I think a feature flag is a better option.

I want to publish, but there are two issues for now:

  • The CI pipeline is not finalized
  • I'm blocking on ort v2 final release.

Perhaps you can help with the first issue?

Best
Musharraf

@thewh1teagle
Copy link
Author

  • I'm blocking on ort v2 final release.

We can publish at least pre release for now.

  • The CI pipeline is not finalized

What do you think about eliminate and merging some crates in the repository? there are too many small crates in my opinion, is that necessary?

@mush42
Copy link
Owner

mush42 commented Aug 31, 2024

What do you think about eliminate and merging some crates in the repository? there are too many small crates in my opinion, is that necessary?

What crates should we merge?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants