-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Linux] Add flatpak #7
Comments
There is a working tauri app on flathub here: https://github.com/flathub/in.cinny.Cinny EDIT: I got basic functionality working, but there are some problems to be worked out before submitting to flathub. Code is here: https://github.com/freundTech/flathub/tree/add-music-assistant-companion
|
That is super cool! If you need any help or have questions feel free to reach out! Either here or on the Discord |
To be published on flathub music-assistant will need an appstream metainfo file. That file includes all the information that will be shown on flathub.org and your distro's software manager, such an name, description, icon, screenshots, ... While it's possible to keep the appstream metadata with the flatpak build manifest, it is preferred to keep it upstream, so in this repository. I can also create the file once I have the packaging working, but it would probably be better if someone with more experience with music-assistant would create the file and commit it upstream. https://docs.flathub.org/docs/for-app-authors/metainfo-guidelines/ |
Also music-assistant-companion contains a self-updater, which should be disabled when installing from flathub. I can just patch that out, but it would be easier if it were exposed as a cargo feature. |
Hey @freundTech, I created the metainfo file now! Again, thanks a bunch for creating the flatpak! |
Thanks. I'll integrate the metainfo into the build. The tauri updater itself is an optional feature of the tauri crate, however MA Companion adds some UI on top (At least the update button in the system menu and the check for updates button in the setting panel). I'm not that experience with rust myself, so I would have to look up the details for how to do this myself. For now I'm just using a patch in the flatpak build: https://github.com/freundTech/flathub/blob/add-music-assistant-companion/0001-disable-tauri-updater.patch |
I don't want to create a separate issue for that, but how about adding it to Homebrew (for Mac Users) and Chocolatey/WinGet for Windows users? |
Yeah, I dont really have much experience with that myself. But I did try creating a homebrew package, but i dont know if it works. Right now I am trying to publish the app to the app store for mac. |
Hey @freundTech, how is it going with the flatpak bundle? Please don't hesitate to reach out if you need any help 🙂 |
I was busy with exams last week. Have some more time now. I think that I might be able to hack around it using LD_PRELOAD. If not we would need to patch in a notice that using |
Ah, cool! Yeah I'm also busy with exams at the moment 😄 Don't stress it if you don't have the time! I don't have experience with flatpak or xdg, if you dont get mDNS to work, that's totally fine. We can just add a notice as you suggested. |
FYI i switched the companion app to the 2.0 beta, meaning some stuff probably changed. But there seems to be a simple guide to creating the flatpak for v2 https://deploy-preview-1760--tauri-v2.netlify.app/guides/distribute/flatpak/ |
I took a quick look at that page and the template they offer. The main problem I see with it is that they don't build in a flatpak sandbox, but build on the host and then just copy the binary to the flatpak sandbox. This might be fine if you want to distribute the flat pack directly, but isn't going to get you onto flathub (which requires all flatpaks to be built in their CI without internet access at built time). Building outside the sandbox could also potentially lead to linking against wrong versions of system libraries. Also you would need to adjust their template to also copy squeezelite over (which my WIP build script builds from source) |
Yeah, that was also the impression, I got. If you need any help, just reach out |
A flatpak file for installation would be extremely nice since we could add it to FlatHub which would make the app way more accessible for Linux users (Since appimages are kinda annoying to run). RPM would be nice as well
Tauri dosn't currently support bundling to a flatpak though... See tauri-apps/tauri#3619
The text was updated successfully, but these errors were encountered: