Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

should not be extra margin before load fork data #79

Open
tjx666 opened this issue Dec 15, 2021 · 4 comments
Open

should not be extra margin before load fork data #79

tjx666 opened this issue Dec 15, 2021 · 4 comments

Comments

@tjx666
Copy link

tjx666 commented Dec 15, 2021

You can see there is extra margin before load for data

image

@musically-ut
Copy link
Owner

Hi @tjx666!

Thanks for the report!

However, the extra space is actually explicitly included in order to avoid jumps in the layout once the data does load. If it doesn't load (or if there is no notable fork), then too there is no jump, but at the cost of the header taking about 12px more space on the desktop.

@tjx666
Copy link
Author

tjx666 commented Dec 15, 2021

@musically-ut we can move the display position to here or other better:

image

@musically-ut
Copy link
Owner

That's a good idea, I can see that as being an extension option.

However, the primary reason I made this extension was so that when I was just about to create an issue on a repo, I should be able to see the notable forks without leaving the issues page. Putting that info on the repo front would remove it from the other tabs.

@tjx666
Copy link
Author

tjx666 commented Dec 15, 2021

In fact, I ussualy this repository is long time no maintained by check it's last commit. I would better just want click somewhere jump to the stat page for example: https://techgaun.github.io/active-forks/index.html#musically-ut/lovely-forks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants