Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature: Submovieclip Support #18

Open
firebirdxxx opened this issue Feb 17, 2015 · 7 comments
Open

Feature: Submovieclip Support #18

firebirdxxx opened this issue Feb 17, 2015 · 7 comments

Comments

@firebirdxxx
Copy link

At the Moment its Submovieclips are not supported. At parsetime "subtimelines" are parsed correctly. At rendertime only "maintimeline" is rendered.

@tgjones
Copy link

tgjones commented Nov 19, 2015

@iccir I've also just hit this issue. I'm guessing, based on the last commit date to SwiffCore, that you're not working on it any more :) But any information you can share about how difficult it might be to add support for subtimelines, or where in the code would be the place to start working on it, would be really appreciated.

@iccir
Copy link
Member

iccir commented Nov 19, 2015

I haven't looked at this in awhile (it's feature complete for our uses), but, from an e-mail I sent somebody else a long time ago:

  1. You need to keep track of the age of each SwiffPlacedObject per SwiffFrame, for example:
    -[SwiffFrame ageOfPlacedObject:]

  2. You would have to keep a map of placed objects to ages and increment this during frame creation (in -[SwiffSpriteDefinition _parser:didFindShowFrameTag:version:])

  3. In -[SwiffLayer _transitionToFrame:fromFrame:], you would need to check on the age of each placed object, and change the frame displayed by that sprite definition accordingly.

@firebirdxxx
Copy link
Author

Hi,
i am the guy you send the email to. I have implemented this locally. There is still some cleanup to do, but after that i can push it. I think i can find the time by the end of next week.

@iccir
Copy link
Member

iccir commented Nov 19, 2015

Oh sweet! :) I'm not sure if I can take it in this repository (it's tied directly to our shipping product), but please post the fork!

@tgjones
Copy link

tgjones commented Nov 19, 2015

Thanks @iccir and @firebirdxxx, both very helpful responses! @firebirdxxx, if you do push your fork up, please could you post a link here?

@firebirdxxx
Copy link
Author

@tgjones sure i will :)

@tgjones
Copy link

tgjones commented Dec 16, 2015

@firebirdxxx I assume you're busy, and no pressure, but just a reminder that if you do get a chance to upload your submovie fixes, it would be really useful.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants