Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implementation of support for Sony RX10M4 conflicts with the existing Sony getAfPoints() logic #213

Open
capricorn8 opened this issue Feb 16, 2025 · 0 comments
Assignees

Comments

@capricorn8
Copy link
Collaborator

capricorn8 commented Feb 16, 2025

The code to support Sony RX10M4 has been placed in a separate file (SonyRX10M4Delegates.lua) but uses the same class definition (SonyDelegates) as it is used for general support of Sony cameras (SonyDelegates.lua).

Which makes all calls to getAfPoints() for a Sony camera being handled according to the RX10M4 logic.

Quick and easy fix is to let RX10M4 have its own, separate class.

The cleaner solution is to integrate all Sony relevant code in SonyDelegates.lua, as this would make generation of info views (#214 ) more simple.

@capricorn8 capricorn8 self-assigned this Feb 16, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant