Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hostname used by dump1090.py to label data collected #2

Open
keptenkurk opened this issue Jun 4, 2015 · 0 comments
Open

Hostname used by dump1090.py to label data collected #2

keptenkurk opened this issue Jun 4, 2015 · 0 comments

Comments

@keptenkurk
Copy link

In dump1090.py the hostname to be used by collectd is derived from the url where to get the dump1090 data from:
collectd.register_read(callback=handle_read,
data=(instance_name, urlparse.urlparse(url).hostname, url),
name='dump1090.' + instance_name)
collectd.register_read(callback=handle_read_1min,
data=(instance_name, urlparse.urlparse(url).hostname, url),
name='dump1090.' + instance_name + '.1min',
interval=60)
This is valid in the usual cases where data collection and data storing will take place at the same host and/or data is retrieved by using different instances with different urls (like the examples),
However if data collection and storing is separated and the collectd network plugin is used to connect the two processes it appears that other plugins use the Hostname "rpi.lxi" directive at the start of collectd.conf to build the full path of the rrd files (/Datadir/Hostname/Plugin/Module name-Instance).
Wouldn't it be better for dump1090.py to stick to this format and use the Hostname "..." from collectd.conf because now data from different plugins from the same host end up in different /Datadir/Hostname/ trees. which makes it harder to create graphs based on host.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant