Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Show the number of confirmations beyond 6 #78

Open
ShwangShwing opened this issue Apr 8, 2022 · 2 comments
Open

Show the number of confirmations beyond 6 #78

ShwangShwing opened this issue Apr 8, 2022 · 2 comments

Comments

@ShwangShwing
Copy link

I want to be able to see the full number of confirmations, not just 6+ after the sixth confirmation.
I took a quick glance at the code and I can see that it has a specific if statement not to show more than the arbitrary settlement value of 6. Why increase the code complexity to REDUCE the functionality?
Also if someone thinks that it increases the user friendliness, I would like to say that putting a plus after some number doesn't make it more user friendly both if the user knows what it means AND if the user doesn't know what it means.

@acrespo
Copy link
Member

acrespo commented Apr 8, 2022

Hi there!

Thank you for feedback and for taking the time to look at the code. The payment detail screen is certainly in dire need of improvement. We already have cool plans for it but we would like to hear more about what you have to say. For example:

  • Why exactly do you want to see the exact number of confirmations? Are we just talking greater-than-6-number of confirmations?
  • How important do you think that piece of data is? Would you be ok with removing it altogether and keeping just a status (pending, confirmed)? The block explorer link could be used to find out about exact the number of confirmations.

@ShwangShwing
Copy link
Author

Hello,
Well, it all stems from my desire for everything to be transperant. Since 6 is an arbitrary number, I don't see why you can't leave the user to decide the arbitrary number that he considers transaction to be final (you can even keep in mind that the more money the transaction contains, the more sense it makes for you to want this number to be bigger).
I am kind of OK of it being removed.

To be honest I like apps and products that expose more internal things to the end user. I see that this kind of goes against the goal of Muun, but unfortenately other apps (even claiming to be "full lightning" wallets) lack very basic functionality (like manually entering receiver address (and to those "why do you need that" people, please just don't). This app has all the functionality that is needed to send and receive bitcoin without some very cubursome steps (setting up channels or even "running your own node").

I don't like the block explorer link, since I feel that every relevant information should be included in the app itself.

If I was developing this app, I think would include all functionality supported by the protocols in the app (e.g. selecting outputs to spend, confirmation number, replace by fee and such), but hide them in some way so that normies don't see them (e.g. swipe guesture cheat code to see the info). This will satisfy people like me and will ease the debugging on your side.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants