From 0ba0b30ba7beb4e46bae8faebaca0fb175f98268 Mon Sep 17 00:00:00 2001
From: Michael Vogt <mvo@ubuntu.com>
Date: Thu, 2 Nov 2023 16:28:18 +0100
Subject: [PATCH] stages: add new unit test for kickstart stage

This commit adds a simple and lightweight unit test for the new
kickstart options. It's pretty simple but also cheap and runs
fast.
---
 osbuild.spec                  |  2 +-
 stages/test/test_kickstart.py | 32 ++++++++++++++++++++++++++++++++
 tox.ini                       |  2 +-
 3 files changed, 34 insertions(+), 2 deletions(-)
 create mode 100644 stages/test/test_kickstart.py

diff --git a/osbuild.spec b/osbuild.spec
index 16a881566..a2fc4adef 100644
--- a/osbuild.spec
+++ b/osbuild.spec
@@ -152,7 +152,7 @@ bzip2 -9 osbuild.pp
 %py3_install
 
 mkdir -p %{buildroot}%{pkgdir}/stages
-install -p -m 0755 $(find stages -type f) %{buildroot}%{pkgdir}/stages/
+install -p -m 0755 $(find stages -type f -not -name "test_*.py") %{buildroot}%{pkgdir}/stages/
 
 mkdir -p %{buildroot}%{pkgdir}/assemblers
 install -p -m 0755 $(find assemblers -type f) %{buildroot}%{pkgdir}/assemblers/
diff --git a/stages/test/test_kickstart.py b/stages/test/test_kickstart.py
new file mode 100644
index 000000000..22a3b78ca
--- /dev/null
+++ b/stages/test/test_kickstart.py
@@ -0,0 +1,32 @@
+#!/usr/bin/python3
+
+import os.path
+
+import pytest
+
+from osbuild.testutil.imports import import_module_from_path
+
+
+@pytest.mark.parametrize("test_input,expected", [
+    ({"lang": "en_US.UTF-8"}, "lang en_US.UTF-8"),
+    ({"keyboard": "us"}, "keyboard us"),
+    ({"timezone": "UTC"}, "timezone UTC"),
+    ({"lang": "en_US.UTF-8",
+      "keyboard": "us",
+      "timezone": "UTC",
+      },
+     "lang en_US.UTF-8\nkeyboard us\ntimezone UTC"),
+])
+def test_kickstart(tmp_path, test_input, expected):
+    ks_stage_path = os.path.join(os.path.dirname(__file__), "../org.osbuild.kickstart")
+    ks_stage = import_module_from_path("ks_stage", ks_stage_path)
+
+    ks_path = "kickstart/kfs.cfg"
+    options = {"path": ks_path}
+    options.update(test_input)
+
+    ks_stage.main(tmp_path, options)
+
+    with open(os.path.join(tmp_path, ks_path), encoding="utf-8") as fp:
+        ks_content = fp.read()
+    assert ks_content == expected + "\n"
diff --git a/tox.ini b/tox.ini
index 30b1b3b72..031a4d90f 100644
--- a/tox.ini
+++ b/tox.ini
@@ -19,7 +19,7 @@ deps =
     pyyaml
 
 setenv =
-    LINTABLES = osbuild/ assemblers/* devices/* inputs/* mounts/* runners/* sources/* stages/*
+    LINTABLES = osbuild/ assemblers/* devices/* inputs/* mounts/* runners/* sources/* stages/*.* stages/test/*.py
     TYPEABLES = osbuild
 
 passenv =