-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for LZ4 compressed rosbags to the py_rosbag
target
#63
Comments
Sounds good to me. Please feel free to impl this and open a PR. |
I've started implementing on this. These are the changes I currently have for the ros_comm.BUILD.bazel:
I'm currently struggling when importing the python bag module, which tries to load the _roslz4 module. There I get the following error: dynamic module does not define module export function (PyInit__roslz4) I can also open a PR if it's easier to discuss there. |
To read LZ4 compressed rosbags via the py_rosbag target from Python, the roslz4 module needs to be passed as a dependency, as it is dynamically loaded during the imports of the bag.py module. See, in the bag.py implementation in the ros_comm repository.
Can we please add this support to the rule set here?
The text was updated successfully, but these errors were encountered: