Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add packaging dependency to ros_launch #387

Merged
merged 2 commits into from
Oct 30, 2024

Conversation

WilliBrems
Copy link
Contributor

@WilliBrems WilliBrems commented Oct 7, 2024

/ros2_launch_ros/launch_ros/launch_ros/utilities/plugin_support.py imports packaging with from packaging.version import Version. Let's make sure packaging is available. So far it was only transitively available (e.g. via pytest)

@WilliBrems
Copy link
Contributor Author

gentle ping @mvukov .

@mvukov mvukov merged commit 0d10a95 into mvukov:main Oct 30, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants