Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

black app icons on main navigation bar #338

Open
gerbrent opened this issue Sep 2, 2023 · 2 comments
Open

black app icons on main navigation bar #338

gerbrent opened this issue Sep 2, 2023 · 2 comments
Labels

Comments

@gerbrent
Copy link

gerbrent commented Sep 2, 2023

Bug description

Reported via social media here

Summary:

"If one chooses a light color (e.g yellow or light green) while using the Breeze Dark theme, the app icons in the menu bar turn black when it'd be nice if they were white like the system icons."

image

Steps to reproduce

  1. Change theme to Breeze Dark (or presumably any dark theme)

Expected behavior

Icons would be more legible if they we're assigned an appropriate contrast to the theme menu background. In the case of Breeze Dark, white app icons and text are preferable.

@mwalbeck
Copy link
Owner

Thanks for reporting!

It's a slightly tricky one to deal with, and even the official dark theme has inconsistencies in how well it handles certain scenarios. It has been an issue for quite a while, but due to lack of time and limited reports hasn't been a priority. The lack of time is an even bigger factor at the moment, so it's probably not something I'll get around to anytime soon, but if someone is interested in submitting a PR to fix it, I would be happy to review and merge it.

Anyway, I do have a quick workaround for anyone who is affected by this issue, you can add the following snippet to the custom styling box in the theming settings:

.header-left .app-menu-main .app-menu-entry img,
.header-left #nextcloud .logo.logo-icon {
    filter: invert(0) !important;
}

@wilya7
Copy link

wilya7 commented Oct 27, 2024

This workaround stopped working after upgrading to Nextcloud Hub 9 (30.0.1)

Screenshot 2024-10-27 at 08 10 33

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants