Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

In silico USI Proposal #173

Open
mwang87 opened this issue Aug 19, 2021 · 4 comments
Open

In silico USI Proposal #173

mwang87 opened this issue Aug 19, 2021 · 4 comments
Labels
enhancement New feature or request

Comments

@mwang87
Copy link
Owner

mwang87 commented Aug 19, 2021

So there is some need to think about in silico MS/MS from a variety of proteomics and metabolomics sources. With real data, there is no need to think about parameters in generation because the data is data, however with in silico and the differing types of parameters depending upon the tool, requires us to think about how do we encode these succinctly but also expressively.

Metabolomics

CFM-ID 4.0

mzspec:CFMID4:M+H:structure:CCCCC:parameters1=X;parameter2=Y

Proteomics

Prosit

mzspec:PROSIT:Prosit_2019_intensity:peptide:PEPTIDE:CE=10

MS2PIP

@sdrogers
Copy link
Collaborator

I’m a little wary of them being included at all tbh - quality is really not fully demonstrated (for metab at least). Although one benefit of including would make those comparisons easier.

that said, is there really a distinction between these generation params and MS acquisition params? For the latter, all those params are captured in the database entry that the USI resolves to. Wouldn’t the same count for the former? Unless you were proposing generating them on the fly? But if so, the spectrum is no longer permanent (as the generating algorithms change)?

@mwang87
Copy link
Owner Author

mwang87 commented Aug 20, 2021

So my thought was that it would be generated on the fly as you wouldn't know which compounds to generate a priori. Broadly, my own interest is exactly as you mentioned, how do we do comparisons.

I was proposing to generate them on the fly and the lack of a data backing requirement, does introduce the issue of permanence.

I think an alternative approach for what I personally want to achieve (god I love the niceness of the visualizations) is the ability to have people enter their own peaks to plot via API.

@sdrogers
Copy link
Collaborator

Are the in silico tools properly versioned or dockerised? A version (or image tag) could be used in the usi?

If not, could dockerise?

@mwang87
Copy link
Owner Author

mwang87 commented Aug 20, 2021

Yes, many are dockerized, there is an issue of namespacing both the version of the software and the model. I think that is what the library name area would be useful for.

@bittremieux bittremieux added the enhancement New feature or request label Aug 30, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants