Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Need more approved terms (SampleExtractionMethod) #242

Open
Adafede opened this issue Jun 13, 2022 · 3 comments
Open

Need more approved terms (SampleExtractionMethod) #242

Adafede opened this issue Jun 13, 2022 · 3 comments

Comments

@Adafede
Copy link

Adafede commented Jun 13, 2022

Hi,

I am actually trying to add ReDu compliant metadata of previously uploaded MassIVE datasets.

I have samples that were extracted using acidic acetone (1% HCl), could this (or related controlled vocabulary) be added to the list of solvents?

Btw, it looks like the acidity (or basicity) is actually not taken into account within solvents. This might be problematic for many extraction protocols (alkaloids...)

Best,

@mwang87
Copy link
Owner

mwang87 commented Jun 13, 2022

@alan-jarmusch what do you think in representing these additional extractions?

@alan-jarmusch
Copy link
Collaborator

'acetone-hydrochloric acid (99:1)' will be added to "SampleExtractionMethod"
you are correct we do not capture pH information. The point you raise is correct and understood. Given the difficulty of measuring pH in organic solutions - I have defaulted to listed the composition as above (v/v unless otherwise stated)

@Adafede
Copy link
Author

Adafede commented Sep 19, 2022

Perfectly understandable, thanks a lot!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants