Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add rounds model #77

Closed
mwickett opened this issue Jul 10, 2024 · 2 comments · Fixed by #81
Closed

Add rounds model #77

mwickett opened this issue Jul 10, 2024 · 2 comments · Fixed by #81
Assignees

Comments

@mwickett
Copy link
Owner

Games -> Rounds -> Scores

This will make things more straightforward for stat generation (most rounds won, longest / shortest games, etc.)

@mwickett
Copy link
Owner Author

mwickett commented Jul 11, 2024

Couple of stages in here.

  1. Add the rounds model to the DB, as optional for now (because of existing data)
  2. Refactor game logic out to its own file
  3. Break it apart into smaller functions
  4. Try to add some testing (see Get some Playwright tests started #55 )
  5. Fix up handing the more than one player above 75 points issue
  6. Refactor to use rounds
  7. Ship it!

@mwickett
Copy link
Owner Author

mwickett commented Jul 11, 2024

Bug where the game doesn't show as complete after the first player has a winning score. Reproduced on main, so it's not the code change here I don't think.

After entering the score - here I can still add an additional score, which is invalid.

CleanShot 2024-07-10 at 23 02 55@2x

This is after a refresh 👇 so some kind of state issue
CleanShot 2024-07-10 at 23 03 36@2x

@mwickett mwickett linked a pull request Jul 11, 2024 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant