Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rewrite error handling as middleware #2

Open
5 tasks
mwpastore opened this issue Nov 29, 2016 · 0 comments
Open
5 tasks

Rewrite error handling as middleware #2

mwpastore opened this issue Nov 29, 2016 · 0 comments
Assignees
Milestone

Comments

@mwpastore
Copy link
Owner

mwpastore commented Nov 29, 2016

Sinja is jumping through too many hoops to play nicely with Sinatra's built-in error-handling in conjunction with sideloading and UDFs. Let's:

  • Make halt raise errors (as it does currently)
  • Enable :raise_errors
  • Move error normalization and serialization logic to middleware
    • Does an internal call pass through middleware?
  • Don't raise from middleware
  • Allow disabling middleware for testing

Other notes:

  • Make exception config options register error handlers
@mwpastore mwpastore self-assigned this Dec 2, 2016
@mwpastore mwpastore added this to the v1.2 milestone Dec 6, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant