Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove wrappers in v7 #1222

Open
GarthSnyder opened this issue Jun 1, 2021 · 4 comments
Open

Remove wrappers in v7 #1222

GarthSnyder opened this issue Jun 1, 2021 · 4 comments
Assignees

Comments

@GarthSnyder
Copy link
Collaborator

GarthSnyder commented Jun 1, 2021

The current v7 implementation of the Dispatcher protocol requires function wrappers, which create significant noise and maintenance burden.

SE-0299, which provides a way for protocol types to simulate the presence of static members, is likely to make the wrappers unnecessary.

The implementation of SE-0299 is complete and due to be released in Swift 5.5. Use of this feature would make Swift 5.5 a prerequisite for v7.

@GarthSnyder GarthSnyder self-assigned this Jun 1, 2021
@mxcl
Copy link
Owner

mxcl commented Jun 1, 2021

Probs doesn’t need to hold up v7 though, or you think otherwise?

@mxcl
Copy link
Owner

mxcl commented Jun 2, 2021

Like, I believe I can tag 7.0.0 as it stands.

@GarthSnyder
Copy link
Collaborator Author

As far as I know, the current code base should work as-is. If you're hoping to get v7 out before WWDC, this particular update can wait. It won't change the API, though it might change Xcode's code completion or visual display.

I would imagine that an Xcode beta that includes Swift 5.5 will be released for WWDC on June 7. It should be pretty easy to assess at that point whether SE-0299 is going to be of help for v7. If so, I don't think the implementation will take that long.

Just as a general question, are you willing to require a beta version of Xcode in order to support v7?

@mxcl
Copy link
Owner

mxcl commented Jun 2, 2021

If you're hoping to get v7 out before WWDC

This final push is more I have time, WWDC is a coincidence.

Just as a general question, are you willing to require a beta version of Xcode in order to support v7?

Only for betas, I believe is the correct choice there.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants