Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove System log from UI #1405

Open
marcus-oscarsson opened this issue Sep 18, 2024 · 7 comments
Open

Remove System log from UI #1405

marcus-oscarsson opened this issue Sep 18, 2024 · 7 comments

Comments

@marcus-oscarsson
Copy link
Member

We would like to propose to remove the System log tab/view completely from the UI. It does not really add any useful functionality and we don't want to propagate this sort of information to the UI (at least not here at ESRF). What do the rest of you think of removing this from the UI.

image

@marcus-oscarsson
Copy link
Member Author

@elmjag, @meguiraun @fabcor-maxiv, what do you think ?

@elmjag
Copy link
Contributor

elmjag commented Sep 19, 2024

I have no idea if this is somehow used by the users. We in software group don't need that page, as we can see the log in other places. I think it's probably fine to remove it.

A more cautious approach is to make it configurable if the tab is visible or not. Say put a new option into mxcube-web/ui.yaml system_log_visible, with default setting false.

Wait X amount of months. If nobody asks about the missing system log tab, just delete it. If somebody is missing the tab, we add documentation on how to make it visible.

@marcus-oscarsson
Copy link
Member Author

I agree that would be a more cautious approach. However we are sure that nobody is using it here, and we actually don't want to propagate this sort of information to the UI. If you guys have a doubt we can make it configurable otherwise Ill suggest to simply remove it

@meguiraun
Copy link
Contributor

I rarely use this tab, I usually go and check the log file or a kibana dashboard. I checked with our scientist and they don't use it much.

I am ok with removing it.

@fabcor-maxiv
Copy link
Contributor

I do not think I have ever used this.

@marcus-oscarsson
Copy link
Member Author

:), Ok I think that settles it. Lets remove it. You can send all complains of it missing to me :)

@elmjag
Copy link
Contributor

elmjag commented Sep 20, 2024

Yes, remove it!

Try to do it in one commit, then in case we'll need to bring it back, it would be easier :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants