Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support "node", "chrome", "msedge", "extensionHost" debugTypes. #68

Open
80avin opened this issue Apr 14, 2024 · 0 comments
Open

Support "node", "chrome", "msedge", "extensionHost" debugTypes. #68

80avin opened this issue Apr 14, 2024 · 0 comments

Comments

@80avin
Copy link

80avin commented Apr 14, 2024

As can be seen in vscode-js-debug/src/common/contributionUtils.ts, the "pwa-*" debug types are not preferred.

Also, as seen in https://github.com/microsoft/vscode-js-debug/blob/2152210dc7c3933e2b4ef7c72d72cf2fef765760/src/build/generate-contributions.ts#L1090-L1098 , vscode will generate a warning if non preferred debug types are used.

Hence, I suggest we add the debug types "node", "chrome", "msedge", "extensionHost" in addition to "pwa-*" versions of these.

This also creates issues when we are importing the autogenerated .vscode/launch.json file which doesn't have pwa- prefix.

@80avin 80avin changed the title Support "node", "chrome", "msedge", "extensionHost" debugTypes. Support "node", "chrome", "msedge", "extensionHost" debugTypes. Apr 14, 2024
80avin added a commit to 80avin/LazyVim that referenced this issue Apr 14, 2024
80avin added a commit to 80avin/LazyVim that referenced this issue May 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant