Important to consider this one, whilst removing the 3rd party dependency will reduce final package size and a little bit of build time, implementing something ourselves has the overhead of maintenance in the long-term, writing ourselves is not overhead-free.

So my question is this, is the saving of overhead from removing the 3rd party dep more than the overheard we'd be generating by rolling our own? Personally, I'd rather have extra file size and build time than maintaining more code ourselves.

Well, nestedset has:

• Support for linear trees (parent_id)
• Support for left/right id
• Thousands of functions to ensure a tree is really a tree, to fix trees, to build trees etc pp

What we need:

• A forum has a parent id

We're calling one or two functions:

• get tree (where parent_id is null)
• parent relation

Both are one liner functions and one class variable.

On a side note: this change would also allow us to make use of the AbstractCachingModel class to remove some (a lot) of the queries on the index.

Yep, the library is pretty much useless here, and using our own code (like one method) brings a whole lot more benefits.

Cool 👍

The only part of it we're using is the node functionality (parent_id) which can easily be added ourself.

We are using only this one feature?
If we will remove left and right id:

1. How we will handle forum order?
2. How to handle forums in forum in category

• category
  --- forum
  ----- subforum
  ----- subforum
  ----- subforum

Also we need some stuff to create, order or remove forums from ACP.

It is true that nestedset dependency have more features than we need but there are some ready to use. We can make our own trait using some methods from this dependency (MIT license).

At the minute, those are the only features we are using. Ordering can be solved with an order INT DEFAULT 0 column.

Nested sets has some nice features, but from what I remember it doesn't generate very nice queries (this might have changed - we are using a very old version).

Yep, for that moment the queries are ugly.
There are planned subforums like in 1x, right? So anyway we must add two columns: one for order, second for flag forums as parent (for subforums feature).

Ok then, I will remove this package and take up this ugly queries.