Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support Client Hints #31

Open
gfoidl opened this issue Jun 4, 2022 · 9 comments
Open

Support Client Hints #31

gfoidl opened this issue Jun 4, 2022 · 9 comments

Comments

@gfoidl
Copy link
Contributor

gfoidl commented Jun 4, 2022

Google Chrome's developer tools shows a hint about the usage of navigator.userAgent and navigator.userAgentData. More info: Migrate to User-Agent Client Hints

@BenjaminAbt do you have more info if we need to take this into account?

@BenjaminAbt
Copy link
Member

If I understand the navigator thing right, thats a JavaScript DOM API and does not affect requests / our impl.

@BenjaminAbt
Copy link
Member

but maybe we have to update this

public static readonly HashSet<HttpUserAgentPlatformInformation> Platforms = new()

@BenjaminAbt
Copy link
Member

Windows 11 Chrome

Mozilla/5.0 (Windows NT 10.0; Win64; x64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/102.0.5005.63 Safari/537.36

Windows 11 Edge

Mozilla/5.0 (Windows NT 10.0; Win64; x64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/102.0.5005.63 Safari/537.36

Cannot see any changes regarding Win11

@BenjaminAbt
Copy link
Member

But there is this doc

https://docs.microsoft.com/en-us/microsoft-edge/web-platform/how-to-detect-win11

I guess I have to test this

@BenjaminAbt
Copy link
Member

I cannot see any Header Changes in the Developer Tools in Chrome, Edge oder Brave.

@BenjaminAbt
Copy link
Member

Edit: I can see changes in Chrome. I was watching the wrong tab before.

image
User AGent is still present

In Brave:
image
No new tags

In Edge same as Chrome
image

I would suggest we change our behavior: first check the new headers.
Then the user agent.

@gfoidl
Copy link
Contributor Author

gfoidl commented Jun 6, 2022

I would suggest we change our behavior: first check the new headers.
Then the user agent.

Sounds like a good plan.

@BenjaminAbt
Copy link
Member

@BenjaminAbt BenjaminAbt changed the title navigator.userAgentData -- any change / update needed? Support Client Hints Jan 8, 2023
@BenjaminAbt
Copy link
Member

Due to privacy reasons we still do not have client hints in all major browsers
https://www.whatismybrowser.com/detect/client-hints/faq/which-web-browsers-support-client-hints

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants