Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(fulfilment): add order notes #456

Merged
merged 20 commits into from
Jul 17, 2023
Merged

feat(fulfilment): add order notes #456

merged 20 commits into from
Jul 17, 2023

Conversation

joerivanveen
Copy link
Contributor

No description provided.

@codecov
Copy link

codecov bot commented Jul 13, 2023

Codecov Report

Merging #456 (d12a340) into main (e206068) will increase coverage by 0.75%.
The diff coverage is 61.44%.

❗ Current head d12a340 differs from pull request most recent head 25dc3d5. Consider uploading reports for the commit 25dc3d5 to get more accurate results

@@             Coverage Diff              @@
##               main     #456      +/-   ##
============================================
+ Coverage     44.67%   45.42%   +0.75%     
- Complexity     1761     1793      +32     
============================================
  Files           104      110       +6     
  Lines          4334     4394      +60     
============================================
+ Hits           1936     1996      +60     
  Misses         2398     2398              
Impacted Files Coverage Δ
src/Collection/Fulfilment/OrderNotesCollection.php 0.00% <0.00%> (ø)
src/Model/MyParcelRequest.php 78.63% <ø> (ø)
src/Support/Helpers.php 8.36% <ø> (ø)
src/Model/Fulfilment/OrderNote.php 85.29% <85.29%> (ø)
src/Rule/Order/AllPropertiesSetRule.php 100.00% <100.00%> (ø)
src/Rule/Order/MaximumNoteLengthRule.php 100.00% <100.00%> (ø)
src/Rule/Order/OrderNoteAuthorRule.php 100.00% <100.00%> (ø)
src/Validator/Order/OrderNoteValidator.php 100.00% <100.00%> (ø)

... and 5 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@joerivanveen joerivanveen marked this pull request as ready for review July 13, 2023 09:18
@joerivanveen joerivanveen requested a review from a team as a code owner July 13, 2023 09:18
src/Collection/Fulfilment/OrderNotesCollection.php Outdated Show resolved Hide resolved
src/Collection/Fulfilment/OrderNotesCollection.php Outdated Show resolved Hide resolved
src/Collection/Fulfilment/OrderNotesCollection.php Outdated Show resolved Hide resolved
src/Collection/Fulfilment/OrderNotesCollection.php Outdated Show resolved Hide resolved
src/Rule/Order/OrderNoteAuthorRule.php Show resolved Hide resolved
src/Support/Helpers.php Outdated Show resolved Hide resolved
test/Model/Fulfilment/OrderNoteTest.php Outdated Show resolved Hide resolved
test/Model/Fulfilment/OrderNoteTest.php Outdated Show resolved Hide resolved
test/Model/Fulfilment/OrderNoteTest.php Outdated Show resolved Hide resolved
src/Collection/Fulfilment/OrderNotesCollection.php Outdated Show resolved Hide resolved
src/Support/Helpers.php Outdated Show resolved Hide resolved
src/Collection/Fulfilment/OrderNotesCollection.php Outdated Show resolved Hide resolved
src/Collection/Fulfilment/OrderNotesCollection.php Outdated Show resolved Hide resolved
@EdieLemoine EdieLemoine added this pull request to the merge queue Jul 17, 2023
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Jul 17, 2023
@EdieLemoine EdieLemoine merged commit c8e2b5b into main Jul 17, 2023
@EdieLemoine EdieLemoine deleted the feat/add-order-notes branch July 17, 2023 13:35
MyParcelBot pushed a commit that referenced this pull request Jul 17, 2023
## [7.8.0](v7.7.7...v7.8.0) (2023-07-17)

### ✨ New Features

* **fulfilment:** add order notes ([#456](#456)) ([c8e2b5b](c8e2b5b))
@MyParcelBot
Copy link

🎉 This PR is included in version 7.8.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

joerivanveen added a commit that referenced this pull request Mar 14, 2024
joerivanveen pushed a commit that referenced this pull request Mar 14, 2024
## [7.8.0](v7.7.7...v7.8.0) (2023-07-17)

### ✨ New Features

* **fulfilment:** add order notes ([#456](#456)) ([c8e2b5b](c8e2b5b))
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Development

Successfully merging this pull request may close these issues.

4 participants