Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

STATEMIND-48: Calldata reduction #442

Closed
asardon opened this issue Jun 27, 2023 · 1 comment · Fixed by #576 or #582
Closed

STATEMIND-48: Calldata reduction #442

asardon opened this issue Jun 27, 2023 · 1 comment · Fixed by #576 or #582
Assignees
@jpick713

Comments

@asardon
Copy link
Member

asardon commented Jun 27, 2023

Description

The updateOnChainQuote function asks for the full structure of oldOnChainQuote only to calculate its hash afterward.

Same issue:

Recommendation

We recommend changing input data from the structure to its hash to save gas.
@asardon asardon self-assigned this Jun 27, 2023
@asardon asardon added the wontfix This will not be worked on label Jun 27, 2023
@jpick713 jpick713 closed this as completed Jul 1, 2023
@asardon asardon assigned jpick713 and unassigned asardon Jul 21, 2023
@asardon asardon reopened this Jul 21, 2023
@asardon asardon linked a pull request Jul 21, 2023 that will close this issue
Quote hash getter updates #576
Merged
@asardon asardon closed this as completed Aug 9, 2023
@asardon asardon linked a pull request Aug 9, 2023 that will close this issue
Statemind resubmission #582
Merged
@asardon asardon removed the wontfix This will not be worked on label Aug 9, 2023
@asardon
Copy link
Member Author

asardon commented Aug 9, 2023

Was re-opened and fixed in #577

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jpick713 jpick713

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Quote hash getter updates mysofinance/v2
Statemind resubmission mysofinance/v2
2 participants
@asardon @jpick713