Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

STATEMIND-173: Redundant option to set allowAllPairs to false #587

Open
asardon opened this issue Aug 10, 2023 · 0 comments · Fixed by #592
Open

STATEMIND-173: Redundant option to set allowAllPairs to false #587

asardon opened this issue Aug 10, 2023 · 0 comments · Fixed by #592
Assignees

Comments

@asardon
Copy link
Member

asardon commented Aug 10, 2023

Description

Within the setGlobalPolicy() function, there exists an option to set the global policy with the allowAllPairs parameter set to false. However, considering the flow of the isAllowed() function, if globalPolicy.allowAllPairs is false:

When a pairPolicy is present, it takes precedence.
When no pairPolicy is present, a given quote is disallowed.
Consequently, the utilization of globalPolicy becomes obsolete when allowAllPairs is set to false.

Recommendation

It is recommended to conduct a review of the globalPolicy workflow, followed by appropriate adjustments. For instance, consider removing the allowAllPairs parameter from globalPolicy.

@asardon asardon self-assigned this Aug 10, 2023
@asardon asardon linked a pull request Aug 10, 2023 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant