Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

STATEMIND-174: The function copyPublishedOnChainQuote() does not update onChainQuoteHistory #588

Open
asardon opened this issue Aug 10, 2023 · 0 comments · Fixed by #594
Open

STATEMIND-174: The function copyPublishedOnChainQuote() does not update onChainQuoteHistory #588

asardon opened this issue Aug 10, 2023 · 0 comments · Fixed by #594
Assignees
@jpick713

Comments

@asardon
Copy link
Member

asardon commented Aug 10, 2023

Description

The function copyPublishedOnChainQuote() is used to copy published on chain quotes and updates isOnChainQuoteFromVault, but it doesn’t update onChainQuoteHistory. This function can be used by approved senders to bypass writing to onChainQuoteHistory.

Recommendation

We recommend to save onChainQuote.generalQuoteInfo.validUntil in isPublishedOnChainQuote and update onChainQuoteHistory when copying a published quote.
@asardon asardon changed the title STATEMIND-173: The function copyPublishedOnChainQuote() does not update onChainQuoteHistory STATEMIND-174: The function copyPublishedOnChainQuote() does not update onChainQuoteHistory Aug 10, 2023
@jpick713 jpick713 linked a pull request Aug 10, 2023 that will close this issue
fixed tests, edited edge case for ltv on global policy and changes fo… #594
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jpick713 jpick713

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fixed tests, edited edge case for ltv on global policy and changes fo… mysofinance/v2
2 participants
@asardon @jpick713