Skip to content

Commit 6a2f1ff

Browse files
committed
fixed some redundant translation strings across UIs
1 parent a45188f commit 6a2f1ff

17 files changed

+35
-2296
lines changed

apps/generic/generic.pro

+2-2
Original file line numberDiff line numberDiff line change
@@ -39,15 +39,15 @@ maemo5: {
3939
SOURCES += main.cpp \
4040
ui/mainwindow.cpp \
4141
ui/settingsdialog.cpp \
42-
ui/connectdialog.cpp \
4342
ui/aboutdialog.cpp \
4443
ui/authenticationdialog.cpp \
4544
qmlapplicationviewer/qmlapplicationviewer.cpp \
45+
ui/connectiondialog.cpp
4646

4747

4848
HEADERS += ui/mainwindow.h \
4949
ui/settingsdialog.h \
50-
ui/connectdialog.h \
5150
ui/aboutdialog.h \
5251
ui/authenticationdialog.h \
5352
qmlapplicationviewer/qmlapplicationviewer.h \
53+
ui/connectiondialog.h

apps/generic/ui/connectdialog.cpp apps/generic/ui/connectiondialog.cpp

+7-7
Original file line numberDiff line numberDiff line change
@@ -18,7 +18,7 @@
1818
* *
1919
****************************************************************************/
2020

21-
#include "connectdialog.h"
21+
#include "connectiondialog.h"
2222

2323
#include <QGridLayout>
2424
#include <QDialogButtonBox>
@@ -33,7 +33,7 @@
3333
#include "libkodimote/kodihostmodel.h"
3434
#include "libkodimote/kodidiscovery.h"
3535

36-
ConnectDialog::ConnectDialog(QWidget *parent) :
36+
ConnectionDialog::ConnectionDialog(QWidget *parent) :
3737
QDialog(parent)
3838
{
3939

@@ -135,7 +135,7 @@ ConnectDialog::ConnectDialog(QWidget *parent) :
135135
#endif
136136
}
137137

138-
void ConnectDialog::accept()
138+
void ConnectionDialog::accept()
139139
{
140140
if(m_stackedLayout->currentIndex() == 0) {
141141
KodiHost *host = Kodi::instance()->hostModel()->host(m_hostView->currentIndex().row());
@@ -153,7 +153,7 @@ void ConnectDialog::accept()
153153
QDialog::accept();
154154
}
155155

156-
void ConnectDialog::showManualLayout()
156+
void ConnectionDialog::showManualLayout()
157157
{
158158
if(m_stackedLayout->currentIndex() != 2) {
159159
m_stackedLayout->setCurrentIndex(2);
@@ -169,12 +169,12 @@ void ConnectDialog::showManualLayout()
169169
enableOkButton();
170170
}
171171

172-
void ConnectDialog::showHostList()
172+
void ConnectionDialog::showHostList()
173173
{
174174
m_stackedLayout->setCurrentIndex(0);
175175
}
176176

177-
void ConnectDialog::enableOkButton()
177+
void ConnectionDialog::enableOkButton()
178178
{
179179
switch(m_stackedLayout->currentIndex()) {
180180
case 0:
@@ -193,7 +193,7 @@ void ConnectDialog::enableOkButton()
193193
}
194194
}
195195

196-
void ConnectDialog::removeHost()
196+
void ConnectionDialog::removeHost()
197197
{
198198
Kodi::instance()->hostModel()->removeHost(m_hostView->currentIndex().row());
199199
enableOkButton();

apps/generic/ui/connectdialog.h apps/generic/ui/connectiondialog.h

+2-2
Original file line numberDiff line numberDiff line change
@@ -29,12 +29,12 @@ class QGridLayout;
2929
class QListView;
3030
class QDialogButtonBox;
3131

32-
class ConnectDialog : public QDialog
32+
class ConnectionDialog : public QDialog
3333
{
3434
Q_OBJECT
3535

3636
public:
37-
explicit ConnectDialog(QWidget *parent = 0);
37+
explicit ConnectionDialog(QWidget *parent = 0);
3838

3939
void setHostname(const QString &hostname);
4040
QString hostname();

apps/generic/ui/mainwindow.cpp

+7-7
Original file line numberDiff line numberDiff line change
@@ -20,7 +20,7 @@
2020

2121
#include "mainwindow.h"
2222
#include "settingsdialog.h"
23-
#include "connectdialog.h"
23+
#include "connectiondialog.h"
2424
#include "aboutdialog.h"
2525
#include "authenticationdialog.h"
2626

@@ -81,8 +81,8 @@ MainWindow::MainWindow(Settings *settings, QWidget *parent) :
8181

8282
QMenuBar *menuBar = new QMenuBar();
8383
QMenu *menu = menuBar->addMenu("Kodi");
84-
menu->addAction(tr("Connect..."), this, SLOT(openConnectDialog()));
85-
menu->addAction(tr("Settings"), this, SLOT(openSettingsDialog()));
84+
menu->addAction(tr("Connect..."), this, SLOT(openConnectionDialog()));
85+
menu->addAction(SettingsDialog::tr("Settings"), this, SLOT(openSettingsDialog()));
8686

8787
QAction *quitAction = menu->addAction("Quit Kodi", Kodi::instance(), SLOT(quit()));
8888
Kodi::instance()->connect(Kodi::instance(), SIGNAL(connectedChanged(bool)), quitAction, SLOT(setEnabled(bool)));
@@ -101,7 +101,7 @@ MainWindow::MainWindow(Settings *settings, QWidget *parent) :
101101
connect(Kodi::instance(), SIGNAL(authenticationRequired(QString,QString)), SLOT(authenticationRequired(QString,QString)), Qt::QueuedConnection);
102102

103103
if(!Kodi::instance()->connecting()) {
104-
openConnectDialog();
104+
openConnectionDialog();
105105
}
106106
}
107107

@@ -134,10 +134,10 @@ void MainWindow::openSettingsDialog()
134134
settings->exec();
135135
}
136136

137-
void MainWindow::openConnectDialog()
137+
void MainWindow::openConnectionDialog()
138138
{
139-
ConnectDialog *settings = new ConnectDialog();
140-
settings->exec();
139+
ConnectionDialog *connection = new ConnectionDialog();
140+
connection->exec();
141141
}
142142

143143
void MainWindow::openAboutDialog()

apps/generic/ui/mainwindow.h

+1-1
Original file line numberDiff line numberDiff line change
@@ -45,7 +45,7 @@ class MainWindow : public QMainWindow
4545
private slots:
4646
void orientationChanged();
4747
void openSettingsDialog();
48-
void openConnectDialog();
48+
void openConnectionDialog();
4949
void openAboutDialog();
5050

5151
#ifdef Q_WS_MAEMO_5

apps/harmattan/qml/AuthenticationSheet.qml apps/harmattan/qml/AuthenticationDialog.qml

+1-1
Original file line numberDiff line numberDiff line change
@@ -23,7 +23,7 @@ import com.nokia.meego 1.0
2323
import Xbmc 1.0
2424

2525
Sheet {
26-
id: connectionSheet
26+
id: authenticationDialog
2727
acceptButtonText: qsTr("OK")
2828
rejectButtonText: qsTr("Cancel")
2929

apps/harmattan/qml/ConnectionSheet.qml apps/harmattan/qml/ConnectionDialog.qml

+4-4
Original file line numberDiff line numberDiff line change
@@ -25,7 +25,7 @@ import QtMobility.connectivity 1.2
2525
import Xbmc 1.0
2626

2727
Sheet {
28-
id: connectionSheet
28+
id: connectionDialog
2929
acceptButtonText: qsTr("Connect")
3030
rejectButtonText: qsTr("Cancel")
3131
acceptButton.enabled: itemView.currentIndex == 0 && hostList.currentIndex >= 0 || hostnameTextField.text != ""
@@ -39,7 +39,7 @@ Sheet {
3939
target: xbmc
4040
onConnectedChanged: {
4141
if(connected)
42-
connectionSheet.reject();
42+
connectionDialog.reject();
4343
}
4444
}
4545

@@ -254,11 +254,11 @@ Sheet {
254254
var newIndex = xbmc.hostModel().createHost(hostnameTextField.text, hostnameTextField.text, portTextField.text, macTextField.text);
255255
xbmc.hostModel().connectToHost(newIndex);
256256
}
257-
connectionSheet.destroy();
257+
connectionDialog.destroy();
258258
}
259259

260260
onRejected: {
261261
print("rejected");
262-
connectionSheet.destroy();
262+
connectionDialog.destroy();
263263
}
264264
}

apps/harmattan/qml/NoConnectionPage.qml

+1-1
Original file line numberDiff line numberDiff line change
@@ -47,7 +47,7 @@ Page {
4747
text: qsTr("Connect...")
4848
anchors.horizontalCenter: parent.horizontalCenter
4949
onClicked: {
50-
var component = Qt.createComponent("ConnectionSheet.qml")
50+
var component = Qt.createComponent("ConnectionDialog.qml")
5151
if (component.status === Component.Ready) {
5252
component.createObject(mainPage).open()
5353
} else {

apps/harmattan/qml/SettingsSheet.qml apps/harmattan/qml/SettingsDialog.qml

+1-1
Original file line numberDiff line numberDiff line change
@@ -22,7 +22,7 @@ import QtQuick 1.1
2222
import com.nokia.meego 1.0
2323

2424
Sheet {
25-
id: connectionSheet
25+
id: settingsDialog
2626
acceptButtonText: qsTr("Save")
2727
rejectButtonText: qsTr("Cancel")
2828

apps/harmattan/qml/main.qml

+4-4
Original file line numberDiff line numberDiff line change
@@ -35,7 +35,7 @@ PageStackWindow {
3535

3636
print("connecting", xbmc.connecting, "connected", xbmc.connected)
3737
if(!(xbmc.connecting || xbmc.connected)) {
38-
var component = Qt.createComponent("ConnectionSheet.qml")
38+
var component = Qt.createComponent("ConnectionDialog.qml")
3939
if (component.status == Component.Ready) {
4040
component.createObject(mainPage).open()
4141
} else {
@@ -98,7 +98,7 @@ PageStackWindow {
9898
MenuItem {
9999
text: qsTr("Connect...")
100100
onClicked: {
101-
var component = Qt.createComponent("ConnectionSheet.qml")
101+
var component = Qt.createComponent("ConnectionDialog.qml")
102102
if (component.status == Component.Ready) {
103103
component.createObject(mainPage).open()
104104
} else {
@@ -129,7 +129,7 @@ PageStackWindow {
129129
text: qsTr("Settings")
130130
onClicked: {
131131
onClicked: {
132-
var component = Qt.createComponent("SettingsSheet.qml")
132+
var component = Qt.createComponent("SettingsDialog.qml")
133133
if (component.status == Component.Ready) {
134134
component.createObject(mainPage).open()
135135
} else {
@@ -171,7 +171,7 @@ PageStackWindow {
171171
target: xbmc
172172
onAuthenticationRequired: {
173173
print("auth required");
174-
var component = Qt.createComponent("AuthenticationSheet.qml")
174+
var component = Qt.createComponent("AuthenticationDialog.qml")
175175
if (component.status == Component.Ready) {
176176
var authSheet = component.createObject(mainPage);
177177
authSheet.hostname = hostname;

apps/sailfish/qml/pages/BrowserPage.qml

+1-1
Original file line numberDiff line numberDiff line change
@@ -86,7 +86,7 @@ Page {
8686
}
8787

8888
MenuItem {
89-
text: qsTr("Now playing")
89+
text: qsTr("Now Playing")
9090
enabled: kodi.activePlayer !== null
9191
onClicked: {
9292
pageStack.push("NowPlayingPage.qml")

apps/sailfish/qml/pages/Keypad.qml

+1-1
Original file line numberDiff line numberDiff line change
@@ -84,7 +84,7 @@ Page {
8484
}
8585

8686
MenuItem {
87-
text: qsTr("Now playing")
87+
text: qsTr("Now Playing")
8888
enabled: kodi.activePlayer !== null
8989
onClicked: {
9090
pageStack.replace("NowPlayingPage.qml")

apps/sailfish/qml/pages/MainPage.qml

+1-1
Original file line numberDiff line numberDiff line change
@@ -111,7 +111,7 @@ Page {
111111
}
112112

113113
MenuItem {
114-
text: qsTr("Now playing")
114+
text: qsTr("Now Playing")
115115
enabled: kodi.activePlayer !== null
116116
onClicked: {
117117
pageStack.push("NowPlayingPage.qml")

apps/sailfish/qml/pages/NowPlayingPage.qml

+1-1
Original file line numberDiff line numberDiff line change
@@ -71,7 +71,7 @@ Page {
7171
}
7272

7373
MenuItem {
74-
text: qsTr("Now playing")
74+
text: qsTr("Now Playing")
7575
enabled: false
7676
}
7777
}

apps/ubuntu/qml/MainPage.qml

+1-1
Original file line numberDiff line numberDiff line change
@@ -284,7 +284,7 @@ KodiPage {
284284
text: qsTr("Options")
285285
Layout.fillWidth: true
286286
onClicked: {
287-
PopupUtils.open(Qt.resolvedUrl("SettingsSheet.qml"), mainPage)
287+
PopupUtils.open(Qt.resolvedUrl("SettingsDialog.qml"), mainPage)
288288
}
289289
}
290290
BottomEdgeButton {
File renamed without changes.

0 commit comments

Comments
 (0)