-
Notifications
You must be signed in to change notification settings - Fork 160
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Error when using with webpack 5 #514
Comments
Have the same issue, did you solve it? |
I just disabled this plugin to continue testing with webpack 5 |
Isn't new webpack persistent caching making this plugin redundant? |
You're right~ |
this is pre webpack5 |
You don't need this plugin with webpack@5, because webpack@5 support cache out of box https://webpack.js.org/configuration/other-options/#cache |
@mzgoddard Could you please add this information to README.md file? |
Webpack 5 supportes module caching out of the box, compare to e.g. mzgoddard/hard-source-webpack-plugin#514 (comment)
…ion 5 & some cleanup (#1301) * chore(docs): some typos missed to replace mustache initially and incorrect handlebars two times (both in package name and URL) * Revert "Merge pull request #2 from pattern-lab/dev" This reverts commit 7812878, reversing changes made to 26db979. * Revert "Merge pull request #1 from pattern-lab/dev" This reverts commit 26db979, reversing changes made to fc90750. * Revert "chore(docs): some typos" This reverts commit 271dc8d. * refactor: removed obsolete dependencies Webpack 5 supportes module caching out of the box, compare to e.g. mzgoddard/hard-source-webpack-plugin#514 (comment) * refactor: removed code out of obsolete dependency * refactor: updated clean-css-loader related dependencies * refactor: updated clean-webpack-plugin dependency and restructured the code according to johnagan/clean-webpack-plugin#106 * refactor: updated webpack-merge dependency * refactor: removed obsolete dependencies this seems to have been removed (intentionally?) by 2cb663d#diff-8c9b7dba764c6bd34aaec36a6a42e7b69d9a46b19712a47706355bb8616d3319L365 * refactor: updated html-webpack-plugin dependency * refactor: updated node-sass-magic-importer dependency * refactor: updated style-loader dependency * refactor: updated svg-sprite-loader dependency * refactor: updated svg-transform-loader dependency * refactor: updated svgo-loader dependency * refactor: updated ts-loader dependency * refactor: updated webpack-cli dependency * refactor: updated copy-webpack-plugin dependency * refactor: updated webpack-dev-middleware dependency "the logger, logLevel and logTime options were removed without replacement." source: https://github.com/webpack/webpack-dev-middleware/releases?after=v4.0.0-rc.1 * refactor: updated mini-css-extract-plugin dependency * refactor(webpackdevmiddleware): quiet has been removed a lot earlier even already * refactor: updated no-emit-webpack-plugin dependency * refactor: updated webpack dependency * refactor: rebuild yarn.lock file * refactor(terserplugin): options had an unknown property 'sourceMap' * refactor(webpack): clean up configuration https://webpack.js.org/migrate/5/#clean-up-configuration * Revert "Merge branch 'dev' into refactor-updated-depencencies-webpack" This reverts commit 8f347df, reversing changes made to e619e63. * refactor(webpack): updated outdated options optimization.namedChunks: true → optimization.chunkIds: 'named' source: https://webpack.js.org/migrate/5/#update-outdated-options * refactor(webpack): updated outdated options optimization.occurrenceOrder: true → optimization: { chunkIds: 'total-size', moduleIds: 'size' } source: https://webpack.js.org/migrate/5/#update-outdated-options * refactor: regenerated yarn.lock * refactor: updated babel-loader dependency * refactor: updated svg-sprite-loader dependency * refactor: updated css-loader dependency * refactor: updated postcss-loader dependency * refactor(postcss-loader): added postcss dependency * refactor: updated autoprefixer dependency * refactor: updated copy-webpack-plugin dependency * refactor: updated webpack dependency * refactor: updated webpackbar dependency * refactor: regenerated yarn.lock file * refactor: regenerated yarn.lock file * refactor(prettier): code rework on the prettier feedback * refactor(prettier): code rework on the prettier feedback * build: regenerated yarn.lock file * refactor: updated webpack-cli dependency * refactor: updated webpack dependency * chore: removed unnecessary require entries * build(webpack): 'stats' is the new 'display' * build: regenerated package-lock.json file * Revert "refactor: updated no-emit-webpack-plugin dependency" * build: regenerated yarn.lock file * chore: reverted node-sass-selector-importer update * refactor: updated sass-loader dependency * chore: code optimizations that are mentioned by the github pipeline as well * chore: rebuild yarn.lock file * build: regenerated yarn.lock * build: regenerated yarn.lock file * refactor: updated clean-webpack-plugin * refactor: updated copy-webpack-plugin * refactor: updated html-webpack-plugin * refactor: updated webpack * refactor: updated webpack-cli * refactor: updated webpack-dev-middleware * refactor: updated webpack-hot-middleware * refactor: updated webpack-merge * refactor: updated webpackbar * refactor: updated mini-css-extract-plugin * refactor: updated babel-loader * refactor: updating clean-css-loader * refactor: updated css-loader * refactor: updated postcss-loader * refactor: updated sass-loader * refactor: updated style-loader * refactor: updated svg-sprite-loader * refactor: updated svgo-loader * refactor: updates ts-loader * chore: updated html-loader * refactor: minimize on productive build is the new default https://github.com/webpack-contrib/html-loader/blob/master/CHANGELOG.md#100-2020-03-19 * refactor(webpack): we need to ignore those references as those are generated independently and won't need to get followed by Webpack * refactor(html-loader): interpolate option got removed that for we need to adapt some other solution for the new preprocessor option * fix(copy-webpack-plugin): correcting the path to prevent webpack errors * refactor: two of the options are now subitems of minimize * chore: this attribute doesn't exist (any more) * Restore packages/core/test/files/_handlebars-test-patterns/atoms/global/helloworld-withdata.hbs * Restore packages/core/test/lineage_hunter_tests.js * Restore packages/development-edition-engine-react/source/_meta/_head.html * Restore packages/core/test/pattern_engines_tests.js * Restore packages/core/test/pseudopattern_hunter_tests.js * Restore packages/engine-handlebars/lib/engine_handlebars.js * Restore packages/engine-nunjucks/lib/engine_nunjucks.js * Restore packages/engine-twig-php/lib/engine_twig_php.js * Restore packages/engine-underscore/_meta/_head.html * Restore packages/engine-underscore/lib/engine_underscore.js * Restore packages/uikit-workshop/src/scripts/actions/app.js * chore: regenerated yarn.lock * chore: corrected package.json * fix: we need to import the cjs from handlebars directly * Update webpack.config.js * Update webpack.config.js * Update webpack.config.js * Update webpack.config.js * chore: regenerated yarn.lock * refactor: updated babel-loader dependency again * refactor: updated clean-css-loader dependency again * refactor: updated svgo-loader dependency again --------- Co-authored-by: Maximilian <[email protected]> Co-authored-by: Josef Bredreck <[email protected]>
- Remove devServer.headers CRACO override because webpack-dev-server already sets this header with this version - Move devServer.watchOptions CRACO override to webpack.watchOptions - Add webpack.resolve.fallback CRACO override because Webpack5 does not inject polyfills automatically. Ref: https://webpack.js.org/configuration/resolve/#resolvefallback - Remove hard-source-webpack-plugin because it is no longer needed with Webpack5. Ref: mzgoddard/hard-source-webpack-plugin#514 (comment)
…ion 5 & some cleanup (pattern-lab#1301) * chore(docs): some typos missed to replace mustache initially and incorrect handlebars two times (both in package name and URL) * Revert "Merge pull request pattern-lab#2 from pattern-lab/dev" This reverts commit 7812878, reversing changes made to 26db979. * Revert "Merge pull request pattern-lab#1 from pattern-lab/dev" This reverts commit 26db979, reversing changes made to fc90750. * Revert "chore(docs): some typos" This reverts commit 271dc8d. * refactor: removed obsolete dependencies Webpack 5 supportes module caching out of the box, compare to e.g. mzgoddard/hard-source-webpack-plugin#514 (comment) * refactor: removed code out of obsolete dependency * refactor: updated clean-css-loader related dependencies * refactor: updated clean-webpack-plugin dependency and restructured the code according to johnagan/clean-webpack-plugin#106 * refactor: updated webpack-merge dependency * refactor: removed obsolete dependencies this seems to have been removed (intentionally?) by pattern-lab@2cb663d#diff-8c9b7dba764c6bd34aaec36a6a42e7b69d9a46b19712a47706355bb8616d3319L365 * refactor: updated html-webpack-plugin dependency * refactor: updated node-sass-magic-importer dependency * refactor: updated style-loader dependency * refactor: updated svg-sprite-loader dependency * refactor: updated svg-transform-loader dependency * refactor: updated svgo-loader dependency * refactor: updated ts-loader dependency * refactor: updated webpack-cli dependency * refactor: updated copy-webpack-plugin dependency * refactor: updated webpack-dev-middleware dependency "the logger, logLevel and logTime options were removed without replacement." source: https://github.com/webpack/webpack-dev-middleware/releases?after=v4.0.0-rc.1 * refactor: updated mini-css-extract-plugin dependency * refactor(webpackdevmiddleware): quiet has been removed a lot earlier even already * refactor: updated no-emit-webpack-plugin dependency * refactor: updated webpack dependency * refactor: rebuild yarn.lock file * refactor(terserplugin): options had an unknown property 'sourceMap' * refactor(webpack): clean up configuration https://webpack.js.org/migrate/5/#clean-up-configuration * Revert "Merge branch 'dev' into refactor-updated-depencencies-webpack" This reverts commit 8f347df, reversing changes made to e619e63. * refactor(webpack): updated outdated options optimization.namedChunks: true → optimization.chunkIds: 'named' source: https://webpack.js.org/migrate/5/#update-outdated-options * refactor(webpack): updated outdated options optimization.occurrenceOrder: true → optimization: { chunkIds: 'total-size', moduleIds: 'size' } source: https://webpack.js.org/migrate/5/#update-outdated-options * refactor: regenerated yarn.lock * refactor: updated babel-loader dependency * refactor: updated svg-sprite-loader dependency * refactor: updated css-loader dependency * refactor: updated postcss-loader dependency * refactor(postcss-loader): added postcss dependency * refactor: updated autoprefixer dependency * refactor: updated copy-webpack-plugin dependency * refactor: updated webpack dependency * refactor: updated webpackbar dependency * refactor: regenerated yarn.lock file * refactor: regenerated yarn.lock file * refactor(prettier): code rework on the prettier feedback * refactor(prettier): code rework on the prettier feedback * build: regenerated yarn.lock file * refactor: updated webpack-cli dependency * refactor: updated webpack dependency * chore: removed unnecessary require entries * build(webpack): 'stats' is the new 'display' * build: regenerated package-lock.json file * Revert "refactor: updated no-emit-webpack-plugin dependency" * build: regenerated yarn.lock file * chore: reverted node-sass-selector-importer update * refactor: updated sass-loader dependency * chore: code optimizations that are mentioned by the github pipeline as well * chore: rebuild yarn.lock file * build: regenerated yarn.lock * build: regenerated yarn.lock file * refactor: updated clean-webpack-plugin * refactor: updated copy-webpack-plugin * refactor: updated html-webpack-plugin * refactor: updated webpack * refactor: updated webpack-cli * refactor: updated webpack-dev-middleware * refactor: updated webpack-hot-middleware * refactor: updated webpack-merge * refactor: updated webpackbar * refactor: updated mini-css-extract-plugin * refactor: updated babel-loader * refactor: updating clean-css-loader * refactor: updated css-loader * refactor: updated postcss-loader * refactor: updated sass-loader * refactor: updated style-loader * refactor: updated svg-sprite-loader * refactor: updated svgo-loader * refactor: updates ts-loader * chore: updated html-loader * refactor: minimize on productive build is the new default https://github.com/webpack-contrib/html-loader/blob/master/CHANGELOG.md#100-2020-03-19 * refactor(webpack): we need to ignore those references as those are generated independently and won't need to get followed by Webpack * refactor(html-loader): interpolate option got removed that for we need to adapt some other solution for the new preprocessor option * fix(copy-webpack-plugin): correcting the path to prevent webpack errors * refactor: two of the options are now subitems of minimize * chore: this attribute doesn't exist (any more) * Restore packages/core/test/files/_handlebars-test-patterns/atoms/global/helloworld-withdata.hbs * Restore packages/core/test/lineage_hunter_tests.js * Restore packages/development-edition-engine-react/source/_meta/_head.html * Restore packages/core/test/pattern_engines_tests.js * Restore packages/core/test/pseudopattern_hunter_tests.js * Restore packages/engine-handlebars/lib/engine_handlebars.js * Restore packages/engine-nunjucks/lib/engine_nunjucks.js * Restore packages/engine-twig-php/lib/engine_twig_php.js * Restore packages/engine-underscore/_meta/_head.html * Restore packages/engine-underscore/lib/engine_underscore.js * Restore packages/uikit-workshop/src/scripts/actions/app.js * chore: regenerated yarn.lock * chore: corrected package.json * fix: we need to import the cjs from handlebars directly * Update webpack.config.js * Update webpack.config.js * Update webpack.config.js * Update webpack.config.js * chore: regenerated yarn.lock * refactor: updated babel-loader dependency again * refactor: updated clean-css-loader dependency again * refactor: updated svgo-loader dependency again --------- Co-authored-by: Maximilian <[email protected]> Co-authored-by: Josef Bredreck <[email protected]>
In webpack5, HardSourceWebpackPlugin can be replaced by cache |
Expected Behavior
Can be used with webpack 5 (currently being beta tested)
Actual Behavior
Errors out
Is an error being thrown?
Steps to Reproduce
Enable
hard-source-webpack-plugin
with webpack 5Operating System, Node, and NPM dependency versions
The text was updated successfully, but these errors were encountered: