Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Possibile to make relationship schema? #4

Open
SoulRaven opened this issue Jun 13, 2013 · 7 comments
Open

Possibile to make relationship schema? #4

SoulRaven opened this issue Jun 13, 2013 · 7 comments

Comments

@SoulRaven
Copy link

Is possible to make this DB to be relational?
to have 2 tables, one for makers and another for model and year?
i ask this because will be more easy and will have smaller footprint because maker will not be on each model the same.

@jspizziri
Copy link

On the same note as @SoulRaven, I highly recommend that:

  1. You normalize your data model to removed extraneous repetitions
    • I.E. a vehicle_make table, a vehicle_model table, and a vehicle_year table.
  2. Rather than offer the data as a SQL scheme and insert, you offer it my something more agnostic, for instance JSON
    • Perhaps you could do a both-and, and have a script that would generate one from the other

I've submitted a PR: #16

@chilion
Copy link

chilion commented Feb 17, 2015

Maby check this one out...

https://github.com/chilion/car-make-and-model-world-wide

@jspizziri
Copy link

@chilion,

You're still locked into MySQL.

@chilion
Copy link

chilion commented Feb 17, 2015

True, but if I see the activity on this repo I seriously doubt if your PR will be approved. You can always adjust it to fit with mine, I will approve and merge it :)

@jspizziri
Copy link

@chilion

It does look like @n8barr isn't paying attention to external activity; however the repo was updated 5mo ago. If there is no activity on the PR I'll definitely consider migrating over to your repo, although if I do that I would probably propose some more structural changes as well, as I have a few ideas on how to improve your data model.

@chilion
Copy link

chilion commented Feb 17, 2015

Jacob, please do that, I don't have the time for it, but there indeed is a
need for some changes.

@chilion
Copy link

chilion commented Mar 24, 2015

@jspizziri looks like there is not activity done here :(

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants