Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Breaks if no lang directory exists #1960

Closed
rrmesquita opened this issue Oct 10, 2024 · 1 comment
Closed

Breaks if no lang directory exists #1960

rrmesquita opened this issue Oct 10, 2024 · 1 comment
Labels

Comments

@rrmesquita
Copy link

Versions:

  • laravel-modules Version: 11.1.4
  • Laravel Version: 11.27.2
  • PHP Version: 8.2.22

Description:

Recently during dependencies update, I noticed several tests in my project started failing.

Digging deeper into which package was causing those failures, I found out that this change was the one responsible. I confirmed that by creating lang/.gitkeep in all modules, and the errors were gone.

I don't think creating such directory should be mandatory, because I don't use the module generator and I like keeping the project lean.

Steps To Reproduce:

  • Sorry, I can't think of any. I haven't tested if the app breaks or if it's just the tests.
@rrmesquita rrmesquita added the bug label Oct 10, 2024
@dcblogdev
Copy link
Collaborator

I can't seem to replicate this, the lang folder is not required, its also not something I tend to use either.

Hard to debug since its working on my installs with no lang directories in my modules.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants