Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Command $name property works but it doesn't support options… #1625

Merged
merged 1 commit into from
Oct 18, 2023

Conversation

Rattone
Copy link
Contributor

@Rattone Rattone commented Oct 14, 2023

…and maybe even arguments

I lost more than an hour to realize that the signature was actually the name, and for this reason I couldn't pass options to the command. This was the only command I had generated from this stub and I was punished :-P

… even arguments

I lost more than an hour to realize that the signature was actually the name, and for this reason I couldn't pass options to the command. This was the only command I had generated from this stub and I was punished :-P
@Rattone
Copy link
Contributor Author

Rattone commented Oct 14, 2023

Sorry for not updating the tests. I tried to understand something but I have doubts with snapshots, should I update them or are they generated somehow?

@dcblogdev
Copy link
Collaborator

for snapshots, you can run tests with -d --update-snapshots which then update the snapshots.

I can do this for you.

@dcblogdev dcblogdev merged commit 11bfcd4 into nWidart:master Oct 18, 2023
1 check failed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants