You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
This repository has been archived by the owner on May 2, 2023. It is now read-only.
Currently, a error is throw due to insufficient ID length. However, this is not a good way to ensure uniqueness of tap names (and on hindsight is actually counterintuitive). Instead, a hash of the container ID should be done and the slice (tap + hash)[:syscall.IFNAMSIZ-1] should be used instead.
The requirement for this is that the process to determine the name should be deterministic. Which using a standard hash function should be able to provide.
Currently, a error is throw due to insufficient ID length. However, this is not a good way to ensure uniqueness of tap names (and on hindsight is actually counterintuitive). Instead, a hash of the container ID should be done and the slice
(tap + hash)[:syscall.IFNAMSIZ-1]
should be used instead.The requirement for this is that the process to determine the name should be deterministic. Which using a standard hash function should be able to provide.
https://github.com/nabla-containers/runnc/blob/master/libcontainer/factory_nabla.go#L98
The text was updated successfully, but these errors were encountered: