Skip to content
This repository has been archived by the owner on May 2, 2023. It is now read-only.

Fix Network Issue #86

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Fix Network Issue #86

wants to merge 2 commits into from

Conversation

lestich
Copy link

@lestich lestich commented Jul 28, 2020

Got Nabla-Containers running on Kubernetes with RuntimeClass and containerd 1.3.4.
I faced the same issue like #83 with every nabla-image.
Removing the deletion of the MasterIP (eth0) solved the problem for me. Another Problem was the already existing network-bridge so i built in a little check for br0.
This fix worked for me, i tested it with docker and k8s/containerd/calico

Closes #83

Copy link

@frzifus frzifus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good stuff, would it make sense to add a unit test?

@frzifus
Copy link

frzifus commented Jul 28, 2020

@lestich
Copy link
Author

lestich commented Jul 28, 2020

Build System seems to be broken. Dep-related errors

@lestich
Copy link
Author

lestich commented Aug 19, 2020

Althoug it works with this fix it's a quite hacky solution. Eth0 keeps its ip address with a placeholder MAC and the Unikernel Interface (ukvmif0) gets the same IP with the MAC address from ETH0. So now we have the same IP address twice with different MAC Adresses. Maybe it's just working because Calico is smart ;).

We need to find some way to save the IP Address of the veth-interface inside the nabla network namespace so we can delete it as proposed in the original source code. Maybe we could create a dummy network interface that keeps the IP and MAC ?

The problem described in #83 occurred to me when the runtime crashed or could not start at all. K8s tries to restart the Container in the same network namespace but now the IP Adress from (veth) eth0 is missing (because it was deleted in the run before) and it keeps crashing ("master should have an ip").

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
2 participants