-
-
Notifications
You must be signed in to change notification settings - Fork 172
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Process all subfiles or subfolders for export disparity #311
Comments
About the feature/option in the title, it is just a matter of motivation. About the flicker reduction problem, it requires scene change detection and resetting the state. |
Nice! I am splitting scenes for Depthcrafter already for the same reason as VDA. While I am using Resolve, several people on the iw3 discord are using PySceneDetect and they say it is better than Resolve. Not sure if it could be or should be implemented into iw3? https://github.com/Breakthrough/PySceneDetect/blob/main As far as output directory structure, I think keeping it the same would be the best. Numbered from 00000000 and up, but you probably mean it will be difficult to implement in that way. |
As far as output directory structure, it is the same as when you process one by one by manual operation. I know about PySceneDetect, but I don't want to depend on OpenCV (CPU processing and numpy array), so I think I will develop code that can run on GPU. I also plan to do scene detection and internal state resetting automatically. |
Sounds good, thank you! |
I have added the batch and recursive options to the dev branch. If you want to try it early, try the dev branch. |
would creating a cache in memory of the last frame of each scene help inform the output of the number of frame its on that way it only is caching one frame in memory at a time only too inform what number frame the next scene starts at? |
What problem are you talking about? I have no idea what you're talking about. If it is about concatenating split scenes, frame numbers should be recorded when splitting. |
No problem I know u have it solved I just wanted more insight is all. |
If you are concerned about file name sequences, you can maintain the original file names by outputting image sequences instead of video and then exporting(convert to depth). EDIT: Sorry. This method does not work with Flicker Reduction (EMA normalize). |
The file name output by iw3 export is PTS (timestamp), so if PTS is not reset when splitting, the file name can be used as the sequence number throughout the entire video. |
I fixed resume option for single video Export or Export disparity. |
I have fixed a problem that the last frame of the video is not output. |
I added a CLI command to split the video by scene/shot.
videos split with this command will keep the original frame number as the file name when exporting. TransNetV2 is used for scene detection. example options, use lossless codec(ffv1)
downscaling (If video is used only for depth estimation, higher resolution is not needed)
reset timestamp (videos can be normally played on video player. note that frame number also reset. )
|
Any chance we can get this option?
Right now with Flicker Reduction on, often the start of a new shot ends up with the whites of the depthmap crushed into the foreground. So what should be a gradual depth in the front becomes a flat wall of someone's face or the landscape that sharply and abruptly starts going back when the 100% white starts to go back to grayscale.
The white crush is an easy fix in sections just by restarting the depthmap render from the first frame of the new shot that messes up, so that it doesn't take the last shot into consideration. It would have to be done for every instance though.
Some of us are using Davinci Resolve to split a movie's shots into clips. If we can get an option for iw3 to process all these clips one after another (and still just put all the depthmap frames in the same folder in order like now), that would completely fix every instance of white crush without further intervention or any substantial addition of processing time. We could likely already do this for rendering the 3d within iw3 just by putting all the clips into separate folder, but there is no option in export disparity to do this. An option to do just all the clips in order would be great, but the same subfolders option would also work with just another step or two. Thanks for your hard work nagadomi!
The text was updated successfully, but these errors were encountered: