Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use a more Rust-friendly type for private inputs #20

Open
nalinbhardwaj opened this issue May 18, 2023 · 0 comments
Open

Use a more Rust-friendly type for private inputs #20

nalinbhardwaj opened this issue May 18, 2023 · 0 comments

Comments

@nalinbhardwaj
Copy link
Owner

nalinbhardwaj commented May 18, 2023 •
edited
Loading

Here we use serde::Value, use something like From<PrimeField> instead and perform the conversion to Circom-friendly JSON in library. This would abstract/simplify lot of the decimal/hex/bytes etc conversions from users of the library:

Nova-Scotia/src/lib.rs

Line 67 in 1bc7e39

private_inputs: Vec<HashMap<String, Value>>,

From https://hackmd.io/80cPXRc0Sa2MPuYX4Wft8w
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@nalinbhardwaj