Skip to content

Commit 0d44dd0

Browse files
committed
fix: accept REVISION as env var, specify in instructions
1 parent 487d2a1 commit 0d44dd0

File tree

2 files changed

+3
-2
lines changed

2 files changed

+3
-2
lines changed

apps/extension/FIREFOX_README.md

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -46,6 +46,7 @@ yarn wasm:build
4646
Then, issue the final build command for the Firefox add-on:
4747

4848
```bash
49+
export REVISION=487d2a1697f50f06e77677df8e081f868d2a5860
4950
yarn build:firefox
5051
```
5152

apps/extension/package.json

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -18,8 +18,8 @@
1818
"build": "yarn wasm:build && yarn clean && yarn build:chrome && yarn build:firefox",
1919
"build:chrome": "yarn clean:chrome && NODE_ENV=production TARGET=chrome REVISION=$(git rev-parse HEAD) webpack-cli && yarn run web-ext build --s ./build/chrome -a ./build/chrome",
2020
"build:chrome:beta": "yarn clean:chrome && NODE_ENV=production BETA_RELEASE=true TARGET=chrome REVISION=$(git rev-parse HEAD) webpack-cli && yarn run web-ext build --s ./build/chrome -a ./build/chrome",
21-
"build:firefox": "yarn clean:firefox && NODE_ENV=production TARGET=firefox REVISION=$(git rev-parse HEAD) webpack-cli && yarn run web-ext build --s ./build/firefox -a ./build/firefox",
22-
"build:firefox:beta": "yarn clean:firefox && NODE_ENV=production BETA_RELEASE=true TARGET=firefox REVISION=$(git rev-parse HEAD) webpack-cli && yarn run web-ext build --s ./build/firefox -a ./build/firefox",
21+
"build:firefox": "yarn clean:firefox && NODE_ENV=production TARGET=firefox webpack-cli && yarn run web-ext build --s ./build/firefox -a ./build/firefox",
22+
"build:firefox:beta": "yarn clean:firefox && NODE_ENV=production BETA_RELEASE=true TARGET=firefox webpack-cli && yarn run web-ext build --s ./build/firefox -a ./build/firefox",
2323
"lint": "eslint src --ext .ts,.tsx",
2424
"lint:fix": "yarn lint -- --fix",
2525
"lint:ci": "yarn lint --max-warnings 0",

0 commit comments

Comments
 (0)