Skip to content

Commit 7fa916b

Browse files
authored
fix: SDK and extension should use the same ledger-namada package (#1376)
* fix: sdk and extension should use the same ledger-namada package * fix: remove unused function
1 parent a640415 commit 7fa916b

File tree

4 files changed

+3
-29
lines changed

4 files changed

+3
-29
lines changed

apps/extension/package.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
{
22
"name": "@namada/extension",
3-
"version": "0.3.4",
3+
"version": "0.3.5",
44
"description": "Namada Keychain",
55
"repository": "https://github.com/anoma/namada-interface/",
66
"author": "Heliax Dev <[email protected]>",

packages/sdk/package.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -65,7 +65,7 @@
6565
"@ledgerhq/hw-transport": "^6.30.0",
6666
"@ledgerhq/hw-transport-webhid": "^6.28.0",
6767
"@ledgerhq/hw-transport-webusb": "^6.28.0",
68-
"@zondax/ledger-namada": "^0.0.6",
68+
"@zondax/ledger-namada": "^1.0.0",
6969
"bignumber.js": "^9.1.1",
7070
"buffer": "^6.0.3",
7171
"slip44": "^3.0.18"

packages/sdk/src/ledger.ts

Lines changed: 0 additions & 17 deletions
Original file line numberDiff line numberDiff line change
@@ -202,23 +202,6 @@ export class Ledger {
202202
return await this.namadaApp.sign(path, buffer);
203203
}
204204

205-
/**
206-
* Sign a Masp tx with the shielded keys associated with the provided (or default) path.
207-
* Throw exception if app is not initialized.
208-
* @async
209-
* @param tx - masp tx data blob to sign
210-
* @param [path] Bip44 path for signing account
211-
* @returns Response signature
212-
*/
213-
public async signMasp(
214-
tx: Uint8Array,
215-
path: string = DEFAULT_LEDGER_BIP44_PATH
216-
): Promise<ResponseSign> {
217-
const buffer = Buffer.from(tx);
218-
219-
return await this.namadaApp.signMasp(path, buffer);
220-
}
221-
222205
/**
223206
* Query status to determine if device has thrown an error.
224207
* Throw exception if app is not initialized.

yarn.lock

Lines changed: 1 addition & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -3725,7 +3725,7 @@ __metadata:
37253725
"@release-it/conventional-changelog": "npm:^8.0.1"
37263726
"@types/jest": "npm:^29.5.12"
37273727
"@types/node": "npm:^20.11.4"
3728-
"@zondax/ledger-namada": "npm:^0.0.6"
3728+
"@zondax/ledger-namada": "npm:^1.0.0"
37293729
babel-jest: "npm:^29.0.3"
37303730
bignumber.js: "npm:^9.1.1"
37313731
buffer: "npm:^6.0.3"
@@ -6033,15 +6033,6 @@ __metadata:
60336033
languageName: node
60346034
linkType: hard
60356035

6036-
"@zondax/ledger-namada@npm:^0.0.6":
6037-
version: 0.0.6
6038-
resolution: "@zondax/ledger-namada@npm:0.0.6"
6039-
dependencies:
6040-
"@ledgerhq/hw-transport": "npm:^6.30.6"
6041-
checksum: 39aabba4be347e5329413be53de82e6519ff9b8e44473d6753cd096b733d075891528d12353108bf653071cbcd6804a9b826703753061428a7f93861607bce80
6042-
languageName: node
6043-
linkType: hard
6044-
60456036
"@zondax/ledger-namada@npm:^1.0.0":
60466037
version: 1.0.0
60476038
resolution: "@zondax/ledger-namada@npm:1.0.0"

0 commit comments

Comments
 (0)