Skip to content

Conversation

@murisi
Copy link
Collaborator

@murisi murisi commented Jan 9, 2025

Describe your changes

Avoid batching transactions when doing hardware wallet signing because it does not yet support them. Instead sign each transaction separately. Also remove the usage of --use-device flags in the test code wherever they are not supported by the CLI. Also resolved #3797 (comment) regarding informing the user about the requests being made to the hardware wallet.

Checklist before merging

  • If this PR has some consensus breaking changes, I added the corresponding breaking:: labels
    • This will require 2 reviewers to approve the changes
  • If this PR requires changes to the docs or specs, a corresponding PR is opened in the namada-docs repo
    • Relevant PR if applies:
  • If this PR affects services such as namada-indexer or namada-masp-indexer, a corresponding PR is opened in that repo
    • Relevant PR if applies:

@murisi murisi force-pushed the murisi/fix-hw-tests-by-unbatching branch from ff3fbb9 to de95286 Compare January 9, 2025 10:14
@codecov
Copy link

codecov bot commented Jan 9, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 74.60%. Comparing base (9527ea9) to head (672d99e).
Report is 5 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #4228   +/-   ##
=======================================
  Coverage   74.59%   74.60%           
=======================================
  Files         342      342           
  Lines      108724   108724           
=======================================
+ Hits        81101    81110    +9     
+ Misses      27623    27614    -9     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@murisi murisi requested review from grarco and tzemanovic January 10, 2025 12:00
@murisi murisi added the merge Ready to merge - mergifyio bot will add the PR to merge queue when all checks pass label Jan 13, 2025
@mergify mergify bot merged commit c0b9f68 into main Jan 13, 2025
25 checks passed
@mergify mergify bot deleted the murisi/fix-hw-tests-by-unbatching branch January 13, 2025 07:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

merge Ready to merge - mergifyio bot will add the PR to merge queue when all checks pass

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants