Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature addition: ens_cure: Enhance disallowed sequence to include "ignored" characters #47

Open
Carbon225 opened this issue Jul 31, 2023 · 1 comment
Open

Feature addition: ens_cure: Enhance disallowed sequence to include "ignored" characters #47

Carbon225 opened this issue Jul 31, 2023 · 1 comment
Labels
enhancement New feature or request

Comments

@Carbon225
Copy link
Contributor

ignored characters are first stripped from the input and the disallowed sequences are reported without them.

ens_process('nick.\ufe0f\ufe0f.eth').error
>>> CurableSequence(code="EMPTY_LABEL", index=4, sequence="..", suggested=".")
ens_process('01\ufe0f--345').error
>>> CurableSequence(code="HYPHEN", index=2, sequence="--", suggested="")
ens_process('01-\ufe0f-345').error
>>> CurableSequence(code="HYPHEN", index=2, sequence="--", suggested="")
ens_process('\ufe0f\'b').error
>>> CurableSequence(code="FENCED_LEADING", index=0, sequence="’", suggested="")

This affects only some CurableErrors. ens_cure still works but uses an additional pass which first removes the ignored characters. The problem is that the reported sequence does not match the input. I will be working on a fix.
@Carbon225 Carbon225 added the bug Something isn't working label Jul 31, 2023
@djstrong djstrong added enhancement New feature or request and removed bug Something isn't working labels Dec 6, 2023
@djstrong djstrong changed the title Bug: Disallowed sequence does not include "ignored" characters Disallowed sequence does not include "ignored" characters Dec 6, 2023
@lightwalker-eth lightwalker-eth changed the title Disallowed sequence does not include "ignored" characters Feature addition: ens_cure: Enhance disallowed sequence to include "ignored" characters Dec 12, 2023
@Carbon225
Copy link
Contributor Author

Implemented cases 2 and 4.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@djstrong @Carbon225