Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Normalize labelhash for ENSRainbow Heal request #211

Open
tk-o opened this issue Feb 11, 2025 · 0 comments
Open

Normalize labelhash for ENSRainbow Heal request #211

tk-o opened this issue Feb 11, 2025 · 0 comments
Labels
ensrainbow ENSRainbow related good first issue Good for newcomers

Comments

@tk-o
Copy link
Contributor

tk-o commented Feb 11, 2025

@lightwalker-eth suggested

Suggest to define some utility function for normalizeLabelhash that takes the provided labelhash and then "normalizes" it into the format expected by the the ENSRainbow heal API.

Of course, normalizeLabelhash should throw an error if the provided labelhash cannot be normalized. This error should flow through the heal function being defined here. In the JSDoc comment on the heal function suggest documenting a @throws for the case that labelhash is not a valid labelhash.

@tk-o tk-o added the ensrainbow ENSRainbow related label Feb 11, 2025
@tk-o tk-o added this to ENSNode Feb 11, 2025
@tk-o tk-o changed the title Normalize labelhash before Normalize labelhash for ENSRainbow Heal request Feb 11, 2025
@lightwalker-eth lightwalker-eth added the good first issue Good for newcomers label Feb 12, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ensrainbow ENSRainbow related good first issue Good for newcomers
Projects
Status: No status
Development

No branches or pull requests

2 participants